MLE-21691: fix bug for service not updated when added new port

[pengzhouml]

No description provided.

[Copilot]

Pull Request Overview

This PR ensures that existing Kubernetes Service resources are updated when new ports are added by introducing patch-based diffing and refactoring service generation.

• Use k8s-objectmatcher to calculate and apply patches in ReconcileServices, updating Services when specs differ.
• Add StsName to serviceParameters and switch selector logic to getSelectorLabels(params.StsName).
• Remove deprecated helper methods (getService, CreateOrUpdateService) and refine import and label merging logic.

Comments suppressed due to low confidence (4)

pkg/k8sutil/service.go:18

• [nitpick] The field name 'StsName' is an unclear abbreviation; consider renaming it to 'StatefulSetName' for clarity.

StsName     string

pkg/k8sutil/service.go:106

• [nitpick] The declaration of svcParams could be simplified by directly using a short variable declaration (e.g., svcParams := generateServiceParams(cr)), removing the redundant zero-value initialization.

var svcParams serviceParameters = serviceParameters{}

pkg/k8sutil/service.go:125

• Consider adding unit or integration tests for the service reconciliation logic, especially covering the update path when new ports are added to verify the patch and update behavior.

svcDef := generateService(service, cr)

pkg/k8sutil/service.go:17

• Add a doc comment for the StsName field in serviceParameters to explain its purpose and usage.

type serviceParameters struct {

[Copilot]

[nitpick] Consider reorganizing imports to follow the project's style guide (e.g., grouping standard library, third-party, and local imports separately) for consistency.