feat: Use handles with Bevy 0.16 support #431
Open
+1,641
−1,386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a serde dependency though. :(
We don't need them since asset's know their language.
It's a duplicate with Script::id now.
I fought with HandlerContext trying to add a Query to it for the longest time.
Log is flooded with these two lines: ```log 2025-06-28T11:46:54.321715Z ERROR bevy_mod_scripting_core::handler: Rhai: Failed to query entities with scripts: Cannot claim access to base type: Global. The base is already claimed by something else in a way which prevents safe access. Location: "/Users/shane/Projects/bevy_mod_scripting/crates/bevy_mod_scripting_core/src/extractors.rs:337". Context: Could not claim exclusive world access 2025-06-28T11:46:54.322046Z ERROR bevy_mod_scripting_core::handler: Lua: Failed to query entities with scripts: Cannot claim access to base type: Global. The base is already claimed by something else in a way which prevents safe access. Location: "/Users/shane/Projects/bevy_mod_scripting/crates/bevy_mod_scripting_core/src/extractors.rs:337". Context: Could not claim exclusive world access ```
* Move from utils::HashMap to platform::collections::HashMap * Change to IntoSchedules vs IntoSystems * Change in namespaces Fix compile issues not seen when using as branch Update bevy_console
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt bad about leaving you with a conflicted merge situation with my "use-handles" #427 with and @alexparlett's #422 "Update to Bevy 0.16", which I also want to see accepted, so I went ahead and merged @alexparlett's work on top of mine in this PR.
I think it'd be nice to have one last BMS release for Bevy 0.15 that includes #427 but that's your call.
I've intentionally left the code in a rough state. I haven't run
cargo formator cleaned up the warnings because I wanted to make the issue of merging and rebasing less fraught. I wouldn't want to clean up #427 if a Bevy 0.15 release is not going to happen.So what is your release plan? Will another BMS for Bevy 0.15 be cut? Which PRs will go into it?