-
-
Notifications
You must be signed in to change notification settings - Fork 45
feat!: Update to Bevy 0.16 #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexparlett
wants to merge
5
commits into
makspll:main
Choose a base branch
from
alexparlett:bevy_0.16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81d34b7
to
1e87793
Compare
* Move from utils::HashMap to platform::collections::HashMap * Change to IntoSchedules vs IntoSystems * Change in namespaces
|
Is there anything holding this up? Formatting needs to be fixed up, anything else to do? |
I'm curious too about the fate of this PR. |
Bump on getting this landed? |
Looking at this now, it looks like there is still some work left on the codegen side which is currently failing. Did you update the generated bindings manually 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This introduces Bevy 0.16 compatibility.
We should probably in a follow up move to the bevy::platform::collections instead of using std to try and align as closely as possible with the no std approach bevy is taking but i didn't want to do it in this one.
Need to quickly restore the ordering where my ide aligned them with the interface order, but thought it would be good to get visibility on the changes.
Notes
bevy_console is pointing at a branch - there is https://github.com/RichoDemus/bevy-console/pull/88/files awaiting review which would allow us to change this.