Issue 31043: Elastic Search interferes with the default sort order of products (changing newest first to oldest first) #36900

rogerdz · 2023-02-21T14:41:17Z

Description (*)

Add sorting condition by product id desc

Additional Information

To maintain backward compatibility, We are going to introduced a store configuration for the Sort Order.
Path for config : Stores-> Configuration -> Catalog-> Catalog-> Storefront -> Product Listing Sort by Order

Related Pull Requests

Fixed Issues (if relevant)

Fixes Elastic Search interferes with the default sort order of products (changing newest first to oldest first) #31043

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

m2-assistant · 2023-02-21T14:41:20Z

Hi @rogerdz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

rogerdz · 2023-02-21T14:49:19Z

@magento run all tests

magento-automated-testing · 2023-02-21T14:49:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2023-02-22T02:20:08Z

@magento run all tests

magento-automated-testing · 2023-02-22T02:20:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2023-02-22T06:09:17Z

@magento give me test instance

magento-deployment-service · 2023-02-22T06:09:21Z

Hi @rogerdz. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2023-02-22T06:14:05Z

Hi @rogerdz, here is your Magento Instance: https://a961f7d4071fdb23cce8cdfa12c1651a.instances.magento-community.engineering
Admin access: https://a961f7d4071fdb23cce8cdfa12c1651a.instances.magento-community.engineering/admin_bb93
Login: b2a75abc
Password: d5ee90711a13

rogerdz · 2023-02-22T07:50:09Z

@magento run all tests

magento-automated-testing · 2023-02-22T07:50:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2023-02-22T07:59:37Z

@magento give me test instance

magento-deployment-service · 2023-02-22T07:59:40Z

Hi @Viper9x. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2023-02-22T08:00:03Z

Hi @Viper9x, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

TuVanDev · 2023-02-22T09:33:06Z

@magento give me test instance

magento-deployment-service · 2023-02-22T09:33:10Z

Hi @Viper9x. Thank you for your request. I'm working on Magento instance for you.

magento-deployment-service · 2023-02-22T09:39:19Z

Hi @Viper9x, here is your Magento Instance: https://a961f7d4071fdb23cce8cdfa12c1651a.instances.magento-community.engineering
Admin access: https://a961f7d4071fdb23cce8cdfa12c1651a.instances.magento-community.engineering/admin_9821
Login: de7e84f9
Password: c38f57fc7b93

TuVanDev · 2023-02-22T10:42:00Z

I confirmed this PR resolved issue #31043. Special thanks to @rogerdz for providing the fix.

rogerdz · 2023-02-23T01:52:08Z

@magento run all tests

magento-automated-testing · 2023-02-23T01:52:18Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2023-02-23T06:12:45Z

@magento run Functional Tests B2B, Functional Tests CE , Functional Tests EE

magento-automated-testing · 2023-02-23T06:12:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

rogerdz · 2023-02-25T08:26:10Z

@magento run all tests

magento-automated-testing · 2023-02-25T08:26:20Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

Den4ik · 2025-01-29T20:04:31Z

@rogerdz Could you please resolve conflict?

engcom-Dash · 2025-07-09T08:00:45Z

@magento run all tests

engcom-Dash · 2025-07-09T10:21:46Z

@magento run all tests

engcom-Dash · 2025-07-09T12:54:19Z

Hello @engcom-Hotel I have fixed all the failed automated test because of the changes done in PR. Also added automated test to verify the descending sort order functionality. Also taken care of the review comments. The 4th point is not included in the changes becuase that is no longer applicable since we are fetching the value from configuration.

Could you please review the changes ? Moving this PR for review.

Thanks!

engcom-Hotel · 2025-07-09T14:18:19Z

@magento run all tests

engcom-Bravo · 2025-07-11T09:49:16Z

@magento run all tests

engcom-Bravo · 2025-07-11T10:33:13Z

Hi @rogerdz,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

Install fresh Magento 2.4-develop

Steps to reproduce

Create a category in Magento with several products in it, all have the position in the category set to the value 1
Go to category page

Before: ✖️

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

engcom-Dash · 2025-07-14T09:15:52Z

Since we have introduced a new store configuration, SVC is failing because of it hence created internal approval JIRA for the same.

SVC: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/36900/d2058a4e8bad2a103834a381c079f900/SemanticVersionChecker/report-magento2.html

hence moving this PR in Pending Approval.

Den4ik

Hi @rogerdz
Could you please review my comment

Den4ik · 2025-07-14T10:14:24Z

app/code/Magento/Catalog/Model/Config/Source/SortOrder.php

+            ['value' => 'ASC', 'label' => __('Ascending')],
+            ['value' => 'DESC', 'label' => __('Descending')],


In my opinion constant usage Select::SQL_ASC or Collection::SORT_ORDER_ASC is more preferable

m2-community-project bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review labels Feb 21, 2023

Den4ik self-requested a review October 3, 2024 14:39

Den4ik self-assigned this Oct 3, 2024

m2-community-project bot added Progress: review and removed Progress: pending review labels Oct 3, 2024

Fixed Static Failures

5ff15c2

engcom-Dash moved this from Changes Requested to Pending Review in Community Dashboard Jul 9, 2025

ct-prd-projects-boards-automation bot added Progress: pending review Progress: review and removed Progress: needs update Progress: pending review labels Jul 9, 2025

ct-prd-projects-boards-automation bot moved this from Pending Review to Review in Progress in Community Dashboard Jul 9, 2025

Merge branch '2.4-develop' into fix-31043

a8c13d4

engcom-Hotel approved these changes Jul 10, 2025

View reviewed changes

ct-prd-projects-boards-automation bot removed the Progress: review label Jul 10, 2025

ct-prd-projects-boards-automation bot moved this from Review in Progress to Ready for Testing in Community Dashboard Jul 10, 2025

ct-prd-projects-boards-automation bot added the Progress: ready for testing label Jul 10, 2025

engcom-Bravo self-assigned this Jul 11, 2025

engcom-Bravo moved this from Ready for Testing to Testing in Progress in Community Dashboard Jul 11, 2025

Merge branch '2.4-develop' into fix-31043

d96183b

engcom-Bravo moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Jul 11, 2025

engcom-Dash added Progress: pending approval and removed Progress: ready for testing labels Jul 14, 2025

engcom-Dash moved this from Extended testing (optional) to To Approve in Community Dashboard Jul 14, 2025

ct-prd-projects-boards-automation bot added the Progress: to approve label Jul 14, 2025

engcom-Dash moved this from To Approve to Pending Approval in Community Dashboard Jul 14, 2025

ct-prd-projects-boards-automation bot removed the Progress: to approve label Jul 14, 2025

Den4ik requested changes Jul 14, 2025

View reviewed changes

		['value' => 'ASC', 'label' => __('Ascending')],
		['value' => 'DESC', 'label' => __('Descending')],

Issue 31043: Elastic Search interferes with the default sort order of products (changing newest first to oldest first) #36900

Are you sure you want to change the base?

Issue 31043: Elastic Search interferes with the default sort order of products (changing newest first to oldest first) #36900

Conversation

rogerdz commented Feb 21, 2023 • edited by engcom-Dash Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Additional Information

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Feb 21, 2023

Uh oh!

rogerdz commented Feb 21, 2023

Uh oh!

magento-automated-testing bot commented Feb 21, 2023

Uh oh!

rogerdz commented Feb 22, 2023

Uh oh!

magento-automated-testing bot commented Feb 22, 2023

Uh oh!

rogerdz commented Feb 22, 2023

Uh oh!

magento-deployment-service bot commented Feb 22, 2023

Uh oh!

magento-deployment-service bot commented Feb 22, 2023

Uh oh!

rogerdz commented Feb 22, 2023

Uh oh!

magento-automated-testing bot commented Feb 22, 2023

Uh oh!

TuVanDev commented Feb 22, 2023

Uh oh!

magento-deployment-service bot commented Feb 22, 2023

Uh oh!

magento-deployment-service bot commented Feb 22, 2023

Uh oh!

TuVanDev commented Feb 22, 2023

Uh oh!

magento-deployment-service bot commented Feb 22, 2023

Uh oh!

magento-deployment-service bot commented Feb 22, 2023

Uh oh!

TuVanDev commented Feb 22, 2023

Uh oh!

rogerdz commented Feb 23, 2023

Uh oh!

magento-automated-testing bot commented Feb 23, 2023

Uh oh!

rogerdz commented Feb 23, 2023

Uh oh!

magento-automated-testing bot commented Feb 23, 2023

Uh oh!

rogerdz commented Feb 25, 2023

Uh oh!

magento-automated-testing bot commented Feb 25, 2023

Uh oh!

Den4ik commented Jan 29, 2025

Uh oh!

engcom-Dash commented Jul 9, 2025

Uh oh!

engcom-Dash commented Jul 9, 2025

Uh oh!

engcom-Dash commented Jul 9, 2025

Uh oh!

engcom-Hotel commented Jul 9, 2025

Uh oh!

engcom-Bravo commented Jul 11, 2025

Uh oh!

engcom-Bravo commented Jul 11, 2025

✔️ QA Passed

Uh oh!

engcom-Dash commented Jul 14, 2025

Uh oh!

Den4ik left a comment

Choose a reason for hiding this comment

Uh oh!

rogerdz commented Feb 21, 2023 •

edited by engcom-Dash

Loading