Skip to content

[Reorder] #30686 - Allow developers to filter order items for reorder #30687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Reorder] #30686 - Allow developers to filter order items for reorder #30687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d0115a
[Reorder] #30686 - Allow developers to filter order items for reorder
PierreLeMaguer Oct 28, 2020
6ea7d52
[Reorder] #30686 - Refactor codes and fix static tests errors
PierreLeMaguer Oct 29, 2020
2164429
Merge branch '2.4-develop' into issue-30686
engcom-Dash Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions app/code/Magento/Sales/Helper/Reorder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,18 @@ public function canReorder($orderId)
return true;
}
}

/**
* Check is it possible to reorder one item.
*
* @param \Magento\Sales\Model\Order\Item $item
* @param \Magento\Catalog\Model\Product $product
* @return bool
*
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
public function canReorderItem($item, $product)
Copy link

@BarnyShergold BarnyShergold Oct 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing return type on prototype

Suggested change
public function canReorderItem($item, $product)
public function canReorderItem($item, $product): bool

{
return true;
}
}
3 changes: 3 additions & 0 deletions app/code/Magento/Sales/Model/Reorder/Reorder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ private function addItemsToCart(Quote $cart, ItemCollection $orderItems, string
}
$product = $products[$productId];
foreach ($orderItems as $orderItem) {
if (!$this->reorderHelper->canReorderItem($orderItem, $product)) {
continue;
}
$this->addItemToCart($orderItem, $cart, clone $product);
}
}
Expand Down