[Reorder] #30686 - Allow developers to filter order items for reorder #30687

PierreLeMaguer · 2020-10-28T12:28:55Z

Description (*)

The new reorder feature is hard to customize for developers.
The idea here is to allow developers to filter order items to reorder thanks to a plugin on the new method app/code/Magento/Sales/Helper/Reorder.php::canReorderItem .

Related Pull Requests

Fixed Issues (if relevant)

Fixes [Reorder feature] Feature very hard to customize #30686

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

…reorder

m2-assistant · 2020-10-28T12:28:57Z

Hi @PierreLeMaguer. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

BarnyShergold · 2020-10-28T16:18:20Z

@magento run all tests

BarnyShergold · 2020-10-28T16:21:24Z

@PierreLeMaguer - It would be useful, as this may not be your only PR in this code area, to add a small description of the change made and how you envisage developers utilising the change - I'm assuming you'd expect them to create a plugin on your new method and manipulate the return? Good for searching at a later date

PierreLeMaguer · 2020-10-28T16:46:28Z

hello @BarnyShergold , thanks for the review. I add a small description to the PR area.

BarnyShergold

The Reorder.php is causing a fail on two B2B static tests. Not sure why but this is for existing code. Will need to be addressed.

Once functional tests have completed check for errors.

BarnyShergold · 2020-10-28T17:39:31Z

app/code/Magento/Sales/Helper/Reorder.php

+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function canReorderItem($item, $product)


Missing return type on prototype

Suggested change

public function canReorderItem($item, $product)

public function canReorderItem($item, $product): bool

PierreLeMaguer · 2020-10-29T07:47:25Z

Hello @BarnyShergold ,

I pushed a new commit to fix static tests.

I checked the functional tests : no error here https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30687/33fbb0a2d1da4801a0d5971f86715e31/Functional/allure-report-ee/index.html#behaviors but one error here https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30687/c3bb69a2652167d4e479a67f5eaee4cf/Functional/allure-report-ce/index.html on the test Magento\FunctionalTestingFramework.functional\MediaGalleryUiSuite ... Not sure that it's linked to my PR.

mbvb1223 · 2020-10-29T08:35:53Z

Hello @BarnyShergold ,

I pushed a new commit to fix static tests.

I checked the functional tests : no error here https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30687/33fbb0a2d1da4801a0d5971f86715e31/Functional/allure-report-ee/index.html#behaviors but one error here https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/30687/c3bb69a2652167d4e479a67f5eaee4cf/Functional/allure-report-ce/index.html on the test Magento\FunctionalTestingFramework.functional\MediaGalleryUiSuite ... Not sure that it's linked to my PR.

It seems the same my PR (#30660).
I also got an error
Magento\FunctionalTestingFramework.functional\MediaGalleryUiSuite
https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4951848: Used in pages link

PierreLeMaguer · 2020-10-29T10:49:41Z

@magento run all tests

BarnyShergold · 2020-10-29T15:21:58Z

@magento run Functional Tests CE

BarnyShergold · 2020-11-02T12:00:15Z

@magento run Functional Tests B2B

BarnyShergold · 2020-11-02T12:00:27Z

@magento run Integration Tests

BarnyShergold · 2020-11-02T16:03:06Z

@magento run Functional Tests B2B

mbvb1223 · 2020-11-04T16:54:10Z

@magento run Functional Tests B2B

romainruaud · 2020-11-05T08:30:20Z

can you please guy tag this PR with "Partner : Smile" ?

I used to be able to do so previously but it seems it's not the case anymore.

Regards

PierreLeMaguer · 2020-11-07T13:47:23Z

@magento run Functional Tests B2B

PierreLeMaguer · 2020-11-13T19:58:59Z

Hello @BarnyShergold , is it ok now ?
Also, is it possible to add the label Parter: Smile ?
Thanks

BarnyShergold

All tests have passed! I've added Smile

magento-engcom-team · 2020-11-17T17:24:50Z

Hi @BarnyShergold, thank you for the review.
ENGCOM-8470 has been created to process this Pull Request
✳️ @BarnyShergold, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

PierreLeMaguer · 2020-12-16T08:09:34Z

@BarnyShergold any news about this PR ? Does it lack anything ?

BarnyShergold · 2021-02-16T11:00:04Z

@PierreLeMaguer I did some checking and currently the feedback is - "This PR is prioritised as P4, we are not able to process P4 PRs currently"

engcom-Dash · 2024-10-28T11:36:03Z

@magento run all tests

engcom-Dash · 2024-10-30T11:42:00Z

Hello @PierreLeMaguer,

Thanks for your contributions!

Moving this PR to on hold since it’s a feature request and we need PO approval for it. Once we get approval, we will proceed accordingly.

Thanks.

engcom-Dash · 2024-12-03T09:40:18Z

Hello @PierreLeMaguer,

Thanks for your contributions!

Moving this PR to on hold since it’s a feature request and we need PO approval for it. Once we get approval, we will proceed accordingly.

Thanks.

Hello @PierreLeMaguer,

Thanks for your contributions!

We've received feedback from the PO, and the requested functionality—overriding the reorder feature in customizations—wasn't intended to work that way. As a result, we can't proceed further with this PR.

Thank you again for your understanding and for your contribution!

[Reorder] magento#30686 - Allow developers to filter order items for …

1d0115a

…reorder

magento-engcom-team added Component: Sales Release Line: 2.4 labels Oct 28, 2020

ghost added the Progress: pending review label Oct 28, 2020

BarnyShergold self-requested a review October 28, 2020 16:22

BarnyShergold self-assigned this Oct 28, 2020

ghost added Progress: review and removed Progress: pending review labels Oct 28, 2020

BarnyShergold requested changes Oct 28, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: review labels Oct 28, 2020

[Reorder] magento#30686 - Refactor codes and fix static tests errors

6ea7d52

sidolov added Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Oct 29, 2020

BarnyShergold added the Partner: Smile Pull Request is created by partner Smile label Nov 17, 2020

BarnyShergold approved these changes Nov 17, 2020

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Nov 17, 2020

engcom-Delta added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Mar 8, 2024

Merge branch '2.4-develop' into issue-30686

2164429

engcom-Dash closed this Dec 3, 2024

m2-community-project bot removed the Progress: ready for testing label Dec 3, 2024

	public function canReorderItem($item, $product)
	public function canReorderItem($item, $product): bool

[Reorder] #30686 - Allow developers to filter order items for reorder #30687

[Reorder] #30686 - Allow developers to filter order items for reorder #30687

Uh oh!

Conversation

PierreLeMaguer commented Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Oct 28, 2020

Uh oh!

BarnyShergold commented Oct 28, 2020

Uh oh!

BarnyShergold commented Oct 28, 2020

Uh oh!

PierreLeMaguer commented Oct 28, 2020

Uh oh!

BarnyShergold left a comment

Choose a reason for hiding this comment

Uh oh!

BarnyShergold Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PierreLeMaguer commented Oct 29, 2020

Uh oh!

mbvb1223 commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PierreLeMaguer commented Oct 29, 2020

Uh oh!

BarnyShergold commented Oct 29, 2020

Uh oh!

BarnyShergold commented Nov 2, 2020

Uh oh!

BarnyShergold commented Nov 2, 2020

Uh oh!

BarnyShergold commented Nov 2, 2020

Uh oh!

mbvb1223 commented Nov 4, 2020

Uh oh!

romainruaud commented Nov 5, 2020

Uh oh!

PierreLeMaguer commented Nov 7, 2020

Uh oh!

PierreLeMaguer commented Nov 13, 2020

Uh oh!

BarnyShergold left a comment

Choose a reason for hiding this comment

Uh oh!

magento-engcom-team commented Nov 17, 2020

Uh oh!

PierreLeMaguer commented Dec 16, 2020

Uh oh!

BarnyShergold commented Feb 16, 2021

Uh oh!

engcom-Dash commented Oct 28, 2024

Uh oh!

engcom-Dash commented Oct 30, 2024

Uh oh!

engcom-Dash commented Dec 3, 2024

Uh oh!

Uh oh!

PierreLeMaguer commented Oct 28, 2020 •

edited

Loading

BarnyShergold Oct 28, 2020 •

edited

Loading

mbvb1223 commented Oct 29, 2020 •

edited

Loading