-
Notifications
You must be signed in to change notification settings - Fork 870
[ci] Drop non-HyperDebug CW310 bitstream for testing #27644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The only tests which do not use HyperDebug are the PMOD tests. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
This bitstream is not used by CI, only by nightlies where it will continue to be built. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
Needs a longer timeout, but seems to work okay now. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
These are now equivalent. Signed-off-by: James Wainwright <james.wainwright@lowrisc.org>
I ran a nightly for this branch, it looks okay https://github.com/lowRISC/opentitan/actions/runs/16322328725 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, it will save a lot of time in CI :)
Were you thinking that the non-hyperdebug variant would essentially not be in the bitstream cache anymore? (Keep in mind that bitstream cache management grabs whatever is in a given commit's entry, so this bitstream will not generally be present.) |
Yes, more or less. The nightly CI will still upload the bitstream every 24 hours, but the only execution environment using it is the custom one in I think it’s only lowRISC running PMOD tests so we should be able to deal with the potentially outdated bitstream. Longer term we’re thinking of making a board that sits on top of the HyperDebug/Nucleo board with PMOD ports. The idea would be to continue routing MIOs from the Xilinx chip to HyperDebug and only deasserting reset for the PMOD connections for PMOD tests. |
I think @a-will has a point though that because the bitstream cache always assume that each commit has either all bitstreams or none, it could gte confused, not just for the PMOD but for the other bitstreams as well. It's not hard to fix the cache to use different commits per design though. I can look into it. |
Good point, let's block merging this until the Bazel rules can deal with a partial cache |
This should already be possible. I had set the rules up to point to the vivado targets when the cache is missing one of the known builds.
The repo label might be problematic when OT is not the main module, though. 🤔 In any case, I didn't mean to say there was a problem. I only wanted to make sure dropping this board target for general use was a known effect. It's our least expensive option, and it doesn't rely on special (and unreliable, due to the connector mating...) boards that aren't sold anywhere. ...but I am okay with getting rid of it, personally. |
Thanks @a-will, me and Amaury discussed and think it's okay. The |
@moidx - could you please take a look at this on behalf of @timothytrippel |
This PR moves CW310 execution environments to the HyperDebug bitstream and disables the non-HyperDebug bitstream build in CI.
Only PMOD tests need the non-HyperDebug bitstream. They run in nightlies and build the bitstream there.