Skip to content

Created openproject.conf.sample #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Created openproject.conf.sample #669

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
618ac3a
Created openproject.conf.sample
HammyHavoc Apr 13, 2024
bab57cd
Update openproject.conf.sample
HammyHavoc Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions openproject.conf.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
## Version 2024/04/13
# make sure that your OpenProject container is named OpenProject
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are issues on some systems with upper case characters

# make sure that your DNS has a record set for openproject

server {
listen 443 ssl;
listen [::]:443 ssl;

server_name openproject.*;
include /config/nginx/ssl.conf;
client_max_body_size 0;

location / {
include /config/nginx/proxy.conf;
include /config/nginx/resolver.conf;
set $upstream_app OpenProject;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there are issues on some systems with upper case characters

set $upstream_port 8080;
set $upstream_proto https;
proxy_pass $upstream_proto://$upstream_app:$upstream_port;
proxy_set_header X-Forwarded-Host $upstream_app:$upstream_port;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong. We have X-Forwarded-Host set here
https://github.com/linuxserver/docker-swag/blob/41cb7cb10423ac9b2708a55b94e6901955199d49/root/defaults/nginx/proxy.conf.sample#L28
We intentionally use the $host variable as it provides information about the visiting client to the header, and thus to the application.

The values you are passing here would essentially be static, and not reflect anything about the client. Is there a documented requirement for this?

}
}