Created openproject.conf.sample #669
Conversation
Added dateline and description.
| @@ -0,0 +1,22 @@ | |||
| ## Version 2024/04/13 | |||
| # make sure that your OpenProject container is named OpenProject | |||
There was a problem hiding this comment.
I believe there are issues on some systems with upper case characters
| location / { | ||
| include /config/nginx/proxy.conf; | ||
| include /config/nginx/resolver.conf; | ||
| set $upstream_app OpenProject; |
There was a problem hiding this comment.
I believe there are issues on some systems with upper case characters
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
Confirmed. Some systems force lowercase container name resolution. |
| set $upstream_port 8080; | ||
| set $upstream_proto https; | ||
| proxy_pass $upstream_proto://$upstream_app:$upstream_port; | ||
| proxy_set_header X-Forwarded-Host $upstream_app:$upstream_port; |
There was a problem hiding this comment.
This seems wrong. We have X-Forwarded-Host set here
https://github.com/linuxserver/docker-swag/blob/41cb7cb10423ac9b2708a55b94e6901955199d49/root/defaults/nginx/proxy.conf.sample#L28
We intentionally use the $host variable as it provides information about the visiting client to the header, and thus to the application.
The values you are passing here would essentially be static, and not reflect anything about the client. Is there a documented requirement for this?
|
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is locked due to inactivity |
This is for https://www.openproject.org/
Description
Benefits of this PR and context
How Has This Been Tested?
Source / References