ignore LoadBalancer Service if loadBalancerClass is set to cilium #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshleyDumaine
force-pushed
the
lbclass-check
branch
2 times, most recently
from
b93deac to
c93b9d8
Compare
AshleyDumaine
force-pushed
the
lbclass-check
branch
from
c93b9d8 to
5139fc2
Compare
rahulait
reviewed
Apr 30, 2024
| @@ -185,6 +185,11 @@ func (l *loadbalancers) EnsureLoadBalancer(ctx context.Context, clusterName stri | |||
| sentry.SetTag(ctx, "cluster_name", clusterName) | |||
| sentry.SetTag(ctx, "service", service.Name) | |||
|
|
|||
| if service.Spec.LoadBalancerClass != nil && *service.Spec.LoadBalancerClass == "io.cilium/bgp-control-plane" { | |||
| klog.Infof("Skipping NodeBalancer creation for Cilium LoadBalancerClass") | |||
There was a problem hiding this comment.
nit: should we also log service name here in log line?
|
Closing in favor of the CCM instead handling this LB class to create and share instance IPs without NBs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support cases where the linode-CCM is installed but instead of backing a LoadBalancer Service via NodeBalancers, the user wants to leverage Cilium's BGP load balancing via specifying so on the Service's
loadBalancerClass.If the
loadBalancerClassis not specified, the Service will by default be backed by a NodeBalancer as usual.General:
Pull Request Guidelines: