ignore LoadBalancer Service if loadBalancerClass is set to cilium

Author: AshleyDumaine

cloud/linode/loadbalancers.go

@@ -185,6 +185,11 @@ func (l *loadbalancers) EnsureLoadBalancer(ctx context.Context, clusterName stri
 	sentry.SetTag(ctx, "cluster_name", clusterName)
 	sentry.SetTag(ctx, "service", service.Name)
 
+	if *service.Spec.LoadBalancerClass == "io.cilium/bgp-control-plane" {
+		klog.Infof("Skipping NodeBalancer creation for Cilium LoadBalancerClass")
+		return lbStatus, err
+	}
+
 	var nb *linodego.NodeBalancer
 	serviceNn := getServiceNn(service)
 

cloud/linode/loadbalancers_test.go

@@ -122,6 +122,10 @@ func TestCCMLoadBalancers(t *testing.T) {
 			name: "Get Load Balancer",
 			f:    testGetLoadBalancer,
 		},
+		{
+			name: "Create Load Balancer With loadBalancerClass",
+			f:    testCreateNodeBalancerWithLBClass,
+		},
 		{
 			name: "Create Load Balancer Without Firewall",
 			f:    testCreateNodeBalancerWithOutFirewall,
@@ -270,6 +274,48 @@ func stubService(fake *fake.Clientset, service *v1.Service) {
 	_, _ = fake.CoreV1().Services("").Create(context.TODO(), service, metav1.CreateOptions{})
 }
 
+func testCreateNodeBalancerWithLBClass(t *testing.T, client *linodego.Client, _ *fakeAPI) {
+	lbClass := "io.cilium/bgp-control-plane"
+	svc := &v1.Service{
+		ObjectMeta: metav1.ObjectMeta{
+			Name: randString(),
+			UID:  "foobar123",
+			Annotations: map[string]string{
+				annotations.AnnLinodeThrottle:         "15",
+				annotations.AnnLinodeLoadBalancerTags: "fake,test,yolo",
+			},
+		},
+		Spec: v1.ServiceSpec{
+			LoadBalancerClass: &lbClass,
+			Ports: []v1.ServicePort{
+				{
+					Name:     randString(),
+					Protocol: "TCP",
+					Port:     int32(80),
+					NodePort: int32(30000),
+				},
+				{
+					Name:     randString(),
+					Protocol: "TCP",
+					Port:     int32(8080),
+					NodePort: int32(30001),
+				},
+			},
+		},
+	}
+	lb := &loadbalancers{client, "us-west", nil}
+	nodes := []*v1.Node{
+		{ObjectMeta: metav1.ObjectMeta{Name: "node-1"}},
+	}
+	nb, err := lb.EnsureLoadBalancer(context.TODO(), "linodelb", svc, nodes)
+	if err != nil {
+		t.Fatalf("expected a nil error, got %v", err)
+	}
+	if nb != nil {
+		t.Fatalf("expected a nil nb, got %v", nb)
+	}
+}
+
 func testCreateNodeBalancer(t *testing.T, client *linodego.Client, _ *fakeAPI, annMap map[string]string) error {
 	svc := &v1.Service{
 		ObjectMeta: metav1.ObjectMeta{

cloud/linode/service_controller.go

@@ -40,7 +40,7 @@ func (s *serviceController) Run(stopCh <-chan struct{}) {
 				return
 			}
 
-			if service.Spec.Type != "LoadBalancer" {
+			if service.Spec.Type != "LoadBalancer" || *service.Spec.LoadBalancerClass == "io.cilium/bgp-control-plane" {
 				return
 			}