Skip to content

feat: values schema json support and enhanced code editor #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 24, 2025
Merged

feat: values schema json support and enhanced code editor #662

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
371402c
feat: validation schema
dennisvankekem Oct 8, 2025
f06a3ee
feat: errors in code editor, partially finished
dennisvankekem Oct 15, 2025
6012d68
fix: editor enhancements
dennisvankekem Oct 20, 2025
c975809
fix: type errors
dennisvankekem Oct 20, 2025
d2e4e49
feat: added block of documentation
dennisvankekem Oct 20, 2025
ee63d72
fix: capital letters and extra line of doc
dennisvankekem Oct 20, 2025
5fb955f
Merge branch 'main' into APL-1156
dennisvankekem Oct 20, 2025
3949536
Merge remote-tracking branch 'origin/main' into APL-1156
svcAPLBot Oct 21, 2025
c2288f9
fix: small cleanup
dennisvankekem Oct 22, 2025
7ae435a
Merge remote-tracking branch 'origin/main' into APL-1156
svcAPLBot Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/components/Catalog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { applyAclToUiSchema, getSpec } from 'common/api-spec'
import { useAppDispatch } from 'redux/hooks'
import { setError } from 'redux/reducers'
import { makeStyles } from 'tss-react/mui'
import InformationBanner from './InformationBanner'
import CodeEditor from '../pages/workloads/create-edit/WorkloadsCodeEditor'
import Form from './rjsf/Form'
import DeleteButton from './DeleteButton'
Expand Down Expand Up @@ -80,6 +79,7 @@ interface Props extends CrudProps {
workload?: any
workloadName?: string
values?: any
valuesSchema?: any
createWorkload: any
updateWorkload: any
deleteWorkload: any
Expand All @@ -90,6 +90,7 @@ export default function ({
workload,
workloadName,
values,
valuesSchema,
createWorkload,
updateWorkload,
deleteWorkload,
Expand Down Expand Up @@ -206,10 +207,6 @@ export default function ({
)}
</Box>

{workloadValuesJson?.image && checkImageFields(workloadValuesJson?.image) && (
<InformationBanner sx={{ mt: 1 }} message={checkImageFields(workloadValuesJson?.image)} />
)}

<Form
schema={schema}
uiSchema={uiSchema}
Expand All @@ -222,7 +219,7 @@ export default function ({
{...other}
/>

<CodeEditor code={workloadValuesYaml} onChange={setWorkloadValuesYaml} />
<CodeEditor code={workloadValuesYaml} onChange={setWorkloadValuesYaml} validationSchema={valuesSchema} />

<Box sx={{ display: 'flex', alignItems: 'center', ml: 'auto', float: 'right', mt: 2 }}>
<ButtonGroup sx={{ gap: '10px' }}>
Expand Down
Loading