-
Couldn't load subscription status.
- Fork 0
feat: values schema json support and enhanced code editor #662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How hard is it to create a test for the editor based on a simple schema?
|
Hard, because the desired outcome is decided visually in the Monaco editor, I could write tests per function, but the functions kind of work in series, it would be a lot of work also because the console doesn't really have a big testing platform as of this writing. If tests are required, I'd highly recommend to make a separate ticket for it, then first finish the remaining UI work for the workloads and then get back to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation logic works well and the documentation is great! But the validateAndMark function is quite long. We might consider extracting the error-type handlers into separate (helper) functions to improve readability and reduce technical debt.
|
@ferruhcihan your concern for the |
api: linode/apl-api#818
Editor now has error support build in with values.schema.json support!
Screen.Recording.2025-10-15.at.4.00.17.PM.mov
Considerations