Skip to content

Conversation

@dennisvankekem
Copy link
Collaborator

@dennisvankekem dennisvankekem commented Oct 20, 2025

api: linode/apl-api#818

Editor now has error support build in with values.schema.json support!

Screen.Recording.2025-10-15.at.4.00.17.PM.mov

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

Copy link
Contributor

@ElderMatt ElderMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard is it to create a test for the editor based on a simple schema?

@dennisvankekem
Copy link
Collaborator Author

Hard, because the desired outcome is decided visually in the Monaco editor, I could write tests per function, but the functions kind of work in series, it would be a lot of work also because the console doesn't really have a big testing platform as of this writing. If tests are required, I'd highly recommend to make a separate ticket for it, then first finish the remaining UI work for the workloads and then get back to it.

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validation logic works well and the documentation is great! But the validateAndMark function is quite long. We might consider extracting the error-type handlers into separate (helper) functions to improve readability and reduce technical debt.

@dennisvankekem
Copy link
Collaborator Author

@ferruhcihan your concern for the validateAndMark function being too lengthy is valid, but I would personally keep it in the code editor as is. Currently all the functions for the codeEditor that handle codeEditor logic are present in the codeEditor. I think it's fine for now

@dennisvankekem dennisvankekem merged commit 9e3f44c into main Oct 24, 2025
6 checks passed
@dennisvankekem dennisvankekem deleted the APL-1156 branch October 24, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants