Skip to content

fix: very tempory fix for workload character limit #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025
Merged

fix: very tempory fix for workload character limit #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96c30f4
fix: very tempory fix for workload character limit
dennisvankekem Jun 11, 2025
22cc79c
Update src/components/Catalog.tsx
dennisvankekem Jun 12, 2025
b8d19d2
Merge branch 'main' into APL-810
dennisvankekem Jun 12, 2025
ce62435
Merge branch 'main' into APL-810
dennisvankekem Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/components/Catalog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,31 @@ export default function ({
}, [workload, values])

const handleCreateUpdateWorkload = async () => {
/** this is very temporary solution to add max character limit to workloads
*
* REMOVE THIS WHEN MIGRATING TO THE NEW UI
*/
const input = document.getElementById('root_name').parentElement as HTMLInputElement | null
if (input) {
input.style.border = ''
const oldErr = document.getElementById('root-name-error')
if (oldErr) oldErr.remove()
}

if ((data.name || '').length > 16) {
if (input) {
input.style.border = '1px solid red'
const err = document.createElement('p')
err.id = 'root-name-error'
err.textContent = `Workload name cannot be longer than 16 characters`
err.style.color = 'red'
err.style.fontSize = '12px'
input.parentNode.insertBefore(err, input.nextSibling)
}
window.scrollTo({ top: 0, behavior: 'smooth' })
return
}

const workloadBody = omit(data, ['chartProvider', 'chart', 'revision', 'values'])
const chartMetadata = omit(data?.chartMetadata, ['helmChartCatalog', 'helmChart'])
const path = workload?.path
Expand Down
4 changes: 2 additions & 2 deletions src/pages/teams/create-edit/create-edit-teams.validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ export const createTeamApiResponseSchema = yup.object({
name: yup
.string()
.required('Team name is required')
.max(30, 'Team name must be at most 30 characters')
.matches(/^[^A-Z]*$/, 'Team name cannot contain capital letters'),
.max(10, 'Team name must be at most 10 characters')
.matches(/^[^A-Z_]*$/, 'Team name cannot contain capital letters or underscores'),
oidc: yup
.object({
groupMapping: yup.string().optional().default(undefined),
Expand Down