Skip to content

Conversation

@dennisvankekem
Copy link
Collaborator

Considerations

  • I have tested the changes in both light and dark mode.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes for responsiveness in different screen resolutions.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

Copy link
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we can't use Yup validation with this RJSF component, and we also can't rely on RJSF's built-in validation due to the special requirements of the workload component. Hopefully, we'll be able to replace this form component soon. So, LGTM for now.

dennisvankekem and others added 3 commits June 12, 2025 10:33
@ferruhcihan ferruhcihan merged commit fbeb18e into main Jun 12, 2025
5 checks passed
@ferruhcihan ferruhcihan deleted the APL-810 branch June 12, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants