Skip to content

feat: pr checklist #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 8, 2025
Merged

feat: pr checklist #491

Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9a7900b
feat: pr checklist
dennisvankekem Dec 19, 2024
db4cf6b
fix: removed depricated step
dennisvankekem Dec 19, 2024
b7bce8c
Rename pull_request_template.md to PULL_REQUEST_TEMPLATE.md
dennisvankekem Dec 19, 2024
1edfe8d
removed test pass check
dennisvankekem Dec 20, 2024
1c1f8ae
Merge branch 'main' into APL-475
dennisvankekem Dec 20, 2024
579e09e
Merge branch 'main' into APL-475
dennisvankekem Dec 27, 2024
56ba0ca
Merge branch 'main' into APL-475
dennisvankekem Dec 30, 2024
36313c1
Delete .github/workflows/checklist.yml
dennisvankekem Jan 2, 2025
eae98d5
Update PULL_REQUEST_TEMPLATE.md
dennisvankekem Jan 6, 2025
82fc12c
Update PULL_REQUEST_TEMPLATE.md
dennisvankekem Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
## Checklist

- [ ] I have tested the changes in both light and dark mode.
- [ ] I have considered the need for new unit tests.
- [ ] I have tested the changes on a cluster.
- [ ] I have included relevant documentation updates.
- [ ] I have an approved Figma design or have reflected my changes in Figma
- [ ] I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
- [ ] I have tested the changes on mobile devices or simulators to ensure responsiveness.
- [ ] I have tested expected error states and verified that the user is presented with informative error messages.
- [ ] I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).
Loading