Skip to content

Conversation

@dennisvankekem
Copy link
Collaborator

@dennisvankekem dennisvankekem commented Dec 19, 2024

Considerations

  • I have tested the changes in both light and dark mode.
  • I have run all unit tests and ensured they pass.
  • I have considered the need for new unit tests.
  • I have tested the changes on a cluster.
  • I have included relevant documentation updates.
  • I have an approved Figma design or have reflected my changes in Figma
  • I have verified that the UI/UX is consistent in major browsers (e.g., Chrome, Firefox, Safari, Edge).
  • I have tested the changes on mobile devices or simulators to ensure responsiveness.
  • I have tested expected error states and verified that the user is presented with informative error messages.
  • I have tested the feature with unusual or extreme inputs (e.g., very long strings, empty states, clicking a button multiple times quickly).

@dennisvankekem
Copy link
Collaborator Author

this PR needs to be discussed with @ElderMatt and @ferruhcihan

Copy link
Contributor

@j-zimnowoda j-zimnowoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall nice checklist.

@j-zimnowoda j-zimnowoda enabled auto-merge (squash) January 8, 2025 10:04
@j-zimnowoda j-zimnowoda merged commit 2465a25 into main Jan 8, 2025
3 checks passed
@j-zimnowoda j-zimnowoda deleted the APL-475 branch January 8, 2025 10:04
@j-zimnowoda j-zimnowoda restored the APL-475 branch January 8, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants