-
Notifications
You must be signed in to change notification settings - Fork 124
Feature: add dynamic interval support. #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e1fccc5
chore: vibe coding dynamic intervall
remmen-io dfc1fa8
chore: new formula
remmen-io 1a97aa9
chore: simplified the formula
dfd38b7
chore: adjust readme
0a895b4
chore: add metric update for di
cd1151e
chore: add debugging information
a8ab27a
chore: add debug information to filter
da9ff1d
chore: rewrite debug message
40a5083
fix: logger
remmen-io be1fb91
chore: use a clear list for pod calulation
d6a9648
Merge branch 'master' of github.com:remmen-io/chaoskube
remmen-io 2b6f0ba
chore: fix filter
6a3f3be
chore: cleanup
remmen-io f144c8b
chore: remove plan as no longer used
remmen-io ecc63c9
chore: Add annotation filtering for dynamic interval calculation
remmen-io dd20aae
Move time calculation logic out of Run method
remmen-io de5552e
Remove redundant debug check for pod listing logs
remmen-io a78e8fb
chore: filter static pods
remmen-io File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic of finding all possible target pods (after filtering) should pretty much match the logic of
Candidates()
(https://github.com/linki/chaoskube/blob/master/chaoskube/chaoskube.go#L214). Let's try to re-use it.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
Candidates()
filters out too much, which gives a false number to calculate the dynamic interval.For instance,
filterByMinimumAge
orfilterByOwnerReference
, which do not make sense for the calculation.Therefore I recreated the list by filtering only the relevant pods to calculate the interval