Feature: add dynamic interval support. #652
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pod count accuracy by applying annotation filtering to dynamic interval calculations and update tests to validate correct behavior.
linki
reviewed
Jul 9, 2025
linki
reviewed
Jul 9, 2025
|
|
||
| pods = filterByAnnotations(pods, c.Annotations) | ||
|
|
||
| podCount := len(pods) |
There was a problem hiding this comment.
The logic of finding all possible target pods (after filtering) should pretty much match the logic of Candidates() (https://github.com/linki/chaoskube/blob/master/chaoskube/chaoskube.go#L214). Let's try to re-use it.
There was a problem hiding this comment.
The Candidates() filters out too much, which gives a false number to calculate the dynamic interval.
For instance, filterByMinimumAge or filterByOwnerReference, which do not make sense for the calculation.
Therefore I recreated the list by filtering only the relevant pods to calculate the interval
linki
reviewed
Jul 9, 2025
linki
reviewed
Jul 9, 2025
| pods = filterByOwnerReference(pods) | ||
| c.Logger.WithFields(log.Fields{ | ||
| "count": len(pods), | ||
| }).Debug("Final pod count after owner reference filtering") |
There was a problem hiding this comment.
We could think about moving the logging to the end of each filterBy* function instead of having it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic Interval
Add a dynamic interval feature that automatically adjusts the time between pod terminations based on the number of candidate pods in your cluster. This helps ensure appropriate chaos levels in both small and large environments.
How it works
With dynamic interval enabled, chaoskube will calculate the interval between pod terminations using the following formula:
Where:
totalWorkingMinutes= 10 days * 8 hours * 60 minutes = 4800 minutes (we assume that all pods should be killed during 2 work weeks)factoris the configurable dynamic interval factorThe dynamic interval factor lets you control the aggressiveness of the terminations:
factor = 1.0: Standard interval calculationfactor > 1.0: More aggressive terminations (shorter intervals)factor < 1.0: Less aggressive terminations (longer intervals)Example scenarios