-
Notifications
You must be signed in to change notification settings - Fork 97
[cc][dvc][test] Add support for SpecificRecord deserialization in DVRT, and add isCaughtUp API for DVRT CDC #1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunyin8
reviewed
May 15, 2025
...client/src/main/java/com/linkedin/davinci/consumer/BootstrappingVeniceChangelogConsumer.java
Show resolved
Hide resolved
...kedin/davinci/consumer/BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.java
Show resolved
Hide resolved
...kedin/davinci/consumer/BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.java
Show resolved
Hide resolved
xunyin8
reviewed
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, just one minor comment.
...kedin/davinci/consumer/BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.java
Outdated
Show resolved
Hide resolved
xunyin8
previously approved these changes
May 19, 2025
xunyin8
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
BootstrappingVeniceChangelogConsumer
hasn't been updated since the introduction of DVRT CDC.DaVinciClientRecordTransformerTest::testRecordTransformer
has been failing consistently in the CI.Solution
isCaughtUp
API is added to theBootstrappingVeniceChangelogConsumer
interface. Since the originalBootstrappingVeniceChangelogConsumer
implementation is extended fromVeniceAfterImageConsumerImpl
, it already supportsisCaughtUp
.sychronized
tostart
.BootstrappingVeniceChangelogConsumer
, explaining how it behaves differently compared to the regular CDC client.DaVinciClientRecordTransformerTest::testRecordTransformer
pass consistently, we need to ensure that this test runs first.Code changes
Concurrency-Specific Checks
Both reviewer and PR author to verify
synchronized
,RWLock
) are used where needed.ConcurrentHashMap
,CopyOnWriteArrayList
).How was this PR tested?
Does this PR introduce any user-facing or breaking changes?
Any DVRT users will now be able to deserialize keys and values into SpecificRecords, leading to better performance and user experience.