Skip to content

Commit 3554276

Browse files
committed
Fix unit tests
1 parent 6415d0a commit 3554276

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

clients/da-vinci-client/src/test/java/com/linkedin/davinci/consumer/BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImplTest.java

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
import java.util.concurrent.CompletableFuture;
4545
import java.util.concurrent.ExecutionException;
4646
import java.util.concurrent.TimeUnit;
47+
import java.util.concurrent.atomic.AtomicBoolean;
4748
import java.util.concurrent.locks.Condition;
4849
import java.util.concurrent.locks.ReentrantLock;
4950
import org.apache.avro.Schema;
@@ -148,7 +149,8 @@ public void testStartAllPartitions() throws IllegalAccessException, NoSuchFieldE
148149
Field isStartedField =
149150
BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.class.getDeclaredField("isStarted");
150151
isStartedField.setAccessible(true);
151-
assertTrue((Boolean) isStartedField.get(bootstrappingVeniceChangelogConsumer), "isStarted should be true");
152+
AtomicBoolean isStarted = (AtomicBoolean) isStartedField.get(bootstrappingVeniceChangelogConsumer);
153+
assertTrue(isStarted.get(), "isStarted should be true");
152154

153155
verify(mockDaVinciClient).start();
154156

@@ -165,7 +167,8 @@ public void testStartWithEmptyPartitions() throws NoSuchFieldException, IllegalA
165167
Field isStartedField =
166168
BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.class.getDeclaredField("isStarted");
167169
isStartedField.setAccessible(true);
168-
assertTrue((Boolean) isStartedField.get(bootstrappingVeniceChangelogConsumer), "isStarted should be true");
170+
AtomicBoolean isStarted = (AtomicBoolean) isStartedField.get(bootstrappingVeniceChangelogConsumer);
171+
assertTrue(isStarted.get(), "isStarted should be true");
169172

170173
verify(mockDaVinciClient).start();
171174

@@ -183,7 +186,8 @@ public void testStartSpecificPartitions() throws IllegalAccessException, NoSuchF
183186
Field isStartedField =
184187
BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.class.getDeclaredField("isStarted");
185188
isStartedField.setAccessible(true);
186-
assertTrue((Boolean) isStartedField.get(bootstrappingVeniceChangelogConsumer), "isStarted should be true");
189+
AtomicBoolean isStarted = (AtomicBoolean) isStartedField.get(bootstrappingVeniceChangelogConsumer);
190+
assertTrue(isStarted.get(), "isStarted should be true");
187191

188192
verify(mockDaVinciClient).start();
189193

@@ -215,10 +219,12 @@ public void testStop() throws Exception {
215219
Field isStartedField =
216220
BootstrappingVeniceChangelogConsumerDaVinciRecordTransformerImpl.class.getDeclaredField("isStarted");
217221
isStartedField.setAccessible(true);
218-
assertTrue((Boolean) isStartedField.get(bootstrappingVeniceChangelogConsumer), "isStarted should be true");
222+
AtomicBoolean isStarted = (AtomicBoolean) isStartedField.get(bootstrappingVeniceChangelogConsumer);
223+
assertTrue(isStarted.get(), "isStarted should be true");
219224

220225
bootstrappingVeniceChangelogConsumer.stop();
221-
assertFalse((Boolean) isStartedField.get(bootstrappingVeniceChangelogConsumer), "isStarted should be false");
226+
isStarted = (AtomicBoolean) isStartedField.get(bootstrappingVeniceChangelogConsumer);
227+
assertFalse(isStarted.get(), "isStarted should be false");
222228

223229
verify(daVinciClientFactoryMock).close();
224230
}

0 commit comments

Comments
 (0)