Amend for espressif32@~5.2.0 #3

xtrinch · 2022-10-30T20:44:40Z

I managed to fix all the paths and make it compile on espressif32 5.2.0 for esp32 (if a custom sdkconfig is used, also esp32s2 compiles)

I also tested the ADC example on a Lolin32 and it works great!

likeablob

@xtrinch
Sry for the late reply and big thank you for your PR.

Overall LGTM but I left some comments. Could you please check them?

likeablob · 2023-01-21T06:21:40Z

.vscode/settings.json

@@ -10,7 +10,7 @@
  },
  "[python]": {
    "editor.wordBasedSuggestions": true,
-    "editor.formatOnSave": true,
+    // "editor.formatOnSave": true,


Could you turn it back on? Or remove it if you have a specific issue on auto-formatting.

likeablob · 2023-01-21T06:23:43Z

examples/ulp-counter/platformio.ini

 board = esp32dev
 framework = arduino
 monitor_speed = 115200

 lib_deps =
-  https://github.com/likeablob/ulptool-pio#pio/0.1.0
+  https://github.com/xtrinch/ulptool-pio


Looks like a chicken-egg problem 🐣 . Let me fix all the lib_deps references before the next version bump.

likeablob · 2023-01-21T06:38:31Z

examples/ulpcc-adc-s2/include/sdkconfig.h

@@ -0,0 +1,653 @@
+// copied from /home/xtrinch/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32s2/dio_qspi/include/sdkconfig.h 


Could you add some more information about the version used here? (I guess it can be deduced from the platform version.)

Also it would be great if you put some notes on why we need this modified sdkconfig.h, let's say, at ulpcc-adc-s2/README.md or somewhere around.

likeablob · 2023-01-21T06:55:43Z

examples/ulpcc-adc-s2/platformio.ini

+; https://docs.platformio.org/page/projectconf.html
+
+[env:esp32dev]
+platform = espressif32@~5.1.1


Can we use espressif32@~5.2.0 here? At least compilation with pio run finished successfully on my end.

$ grep espressif examples/ulp*/platformio.ini examples/ulp-counter/platformio.ini:platform = espressif32@~5.2.0 examples/ulpcc-adc-s2/platformio.ini:platform = espressif32@~5.1.1 examples/ulpcc-adc/platformio.ini:platform = espressif32@~5.2.0 examples/ulpcc-counter-s2/platformio.ini:platform = espressif32@~5.2.0 examples/ulpcc-counter/platformio.ini:platform = espressif32@~5.2.0

likeablob · 2023-01-21T07:06:59Z

post_extra_script_ulptool.py

    framework_dir = platform.get_package_dir("framework-arduinoespressif32")
-    toolchain_ulp_dir = platform.get_package_dir("toolchain-esp32ulp")
-    toolchain_xtensa_dir = platform.get_package_dir("toolchain-xtensa32")
+    toolchain_ulp_dir = platform.get_package_dir("toolchain-%sulp" % (mcu))


Hmm, not sure why but for the -s2 variants, get_package_dir returns None and I had to install toolchain-esp32s2ulp manually by pio pkg install -t toolchain-esp32s2ulp.
Outdated framework-espidf probably?

$ pio pkg list Resolving esp32dev dependencies... Platform espressif32 @ 5.1.1 (required: espressif32 @ ~5.1.1) ├── framework-arduinoespressif32 @ 3.20004.0 (required: platformio/framework-arduinoespressif32 @ ~3.20004.0) ├── tool-esptoolpy @ 1.30300.0 (required: platformio/tool-esptoolpy @ ~1.30300.0) ├── tool-mklittlefs @ 1.203.210628 (required: platformio/tool-mklittlefs @ ~1.203.0) ├── tool-mkspiffs @ 2.230.0 (required: platformio/tool-mkspiffs @ ~2.230.0) ├── toolchain-riscv32-esp @ 8.4.0+2021r2-patch3 (required: espressif/toolchain-riscv32-esp @ 8.4.0+2021r2-patch3) └── toolchain-xtensa-esp32s2 @ 8.4.0+2021r2-patch3 (required: espressif/toolchain-xtensa-esp32s2 @ 8.4.0+2021r2-patch3) Libraries └── ulptool-pio @ 0.1.0+sha.cb6f38f (required: git+https://github.com/xtrinch/ulptool-pio) $ pio run ... FileNotFoundError: [Errno 2] No such file or directory: 'None/bin/esp32s2ulp-elf-as' *** Error 1 *** [.pio/build/esp32dev/firmware.elf] Exception : An error returned by ulptool. $ pio pkg install -t toolchain-esp32s2ulp $ pio pkg list Resolving esp32dev dependencies... Platform espressif32 @ 5.1.1 (required: espressif32 @ ~5.1.1) ├── framework-arduinoespressif32 @ 3.20004.0 (required: platformio/framework-arduinoespressif32 @ ~3.20004.0) ├── tool-esptoolpy @ 1.30300.0 (required: platformio/tool-esptoolpy @ ~1.30300.0) ├── tool-mklittlefs @ 1.203.210628 (required: platformio/tool-mklittlefs @ ~1.203.0) ├── tool-mkspiffs @ 2.230.0 (required: platformio/tool-mkspiffs @ ~2.230.0) ├── toolchain-esp32s2ulp @ 1.22851.191205 (required: platformio/toolchain-esp32s2ulp @ ^1.22851.191205) ├── toolchain-riscv32-esp @ 8.4.0+2021r2-patch3 (required: espressif/toolchain-riscv32-esp @ 8.4.0+2021r2-patch3) └── toolchain-xtensa-esp32s2 @ 8.4.0+2021r2-patch3 (required: espressif/toolchain-xtensa-esp32s2 @ 8.4.0+2021r2-patch3) Libraries └── ulptool-pio @ 0.1.0+sha.cb6f38f (required: git+https://github.com/xtrinch/ulptool-pio)

Let me check later with a fresh installation but may be we have to explicitly specify additional packages with platform_packages.

likeablob · 2023-01-21T07:15:06Z

src/esp32ulp_build_recipe.py

@@ -90,6 +90,8 @@ def main(argv):
    PATHS['ulptool']   = args.t
    PATHS['ucompiler'] = args.u
    PATHS['xcompiler'] = args.x
+    global MCU


Could you move global MCU to the top of the function definition? (Just for aesthetic reason.)

MCU = "esp32" # ... def main(argv): global MCU parser = argparse.ArgumentParser() ...

likeablob · 2023-01-21T07:21:01Z

src/esp32ulp_build_recipe.py

@@ -266,7 +268,7 @@ def build_ulp(PATHS, ulp_sfiles, board_options, has_s_file):
        console_string += cmd[0] + '\r'

    ## Check if sdkconfig.h md5 hash has changed indicating the file has changed
-    sdk_hash = md5(os.path.join(PATHS['core'] , 'tools', 'sdk', 'include', 'config', 'sdkconfig.h'))
+    sdk_hash = md5(os.path.join(PATHS['core'] , 'tools', 'sdk', MCU, 'dio_qspi', 'include', 'sdkconfig.h'))


(FWIF, it seems there are other variants such as qio_qspi or dout_qspi.

$ ls ~/.platformio/packages/framework-arduinoespressif32@3.20004.0/tools/sdk/esp32/ bin dio_qspi dout_qspi include ld lib qio_qspi qout_qspi sdkconfig

likeablob · 2023-01-21T07:23:52Z

src/ulpcc/include/ulp_c.h

@@ -3,7 +3,6 @@
 /* This simplifies what the following headers pull in */
 #define __ASSEMBLER__

-#include "soc/rtc_cntl_reg.h"


Is it from the upstream change? (Sry for my laziness!)

maxgerhardt · 2023-01-21T13:53:34Z

I fixed up errors occuring in later platform-espressif32 versions in #4, together with improvments on how macros and includes are being passed, since it was hopelessly overflowing the CMD_MAX_LENGTH restriction of Windows.

We also need CI here to automatically verify all examples against a certain platform version to stop regression errors.

Amend for espressif32@~5.2.0

cc228b0

xtrinch mentioned this pull request Oct 30, 2022

Compilation problems KeyError : 'toolchain-xtensa32' #2

Open

xtrinch added 4 commits October 31, 2022 10:25

Explicit espressif32 version

4a8ecdb

Add own include path

c682070

Add ADC example

5887d79

Add s2 example - unfinished

cb6f38f

likeablob reviewed Jan 21, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amend for espressif32@~5.2.0 #3

Amend for espressif32@~5.2.0 #3

xtrinch commented Oct 30, 2022 •

edited

Loading

likeablob left a comment •

edited

Loading

likeablob Jan 21, 2023

likeablob Jan 21, 2023

likeablob Jan 21, 2023 •

edited

Loading

likeablob Jan 21, 2023

likeablob Jan 21, 2023

likeablob Jan 21, 2023

likeablob Jan 21, 2023

likeablob Jan 21, 2023

maxgerhardt commented Jan 21, 2023 •

edited

Loading

		@@ -0,0 +1,653 @@
		// copied from /home/xtrinch/.platformio/packages/framework-arduinoespressif32/tools/sdk/esp32s2/dio_qspi/include/sdkconfig.h

Amend for espressif32@~5.2.0 #3

Are you sure you want to change the base?

Amend for espressif32@~5.2.0 #3

Conversation

xtrinch commented Oct 30, 2022 • edited Loading

likeablob left a comment • edited Loading

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

likeablob Jan 21, 2023 • edited Loading

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

likeablob Jan 21, 2023

Choose a reason for hiding this comment

maxgerhardt commented Jan 21, 2023 • edited Loading

xtrinch commented Oct 30, 2022 •

edited

Loading

likeablob left a comment •

edited

Loading

likeablob Jan 21, 2023 •

edited

Loading

maxgerhardt commented Jan 21, 2023 •

edited

Loading