provider: network operations #1115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2025
gammazero
approved these changes
Jul 25, 2025
There was a problem hiding this comment.
Please simplify code by using package github.com/ipfs/go-test/random
After that, ok to merge
Comment on lines
+36
to
+42
| func genRandPeerID(t *testing.T) peer.ID { | ||
| _, pub, err := crypto.GenerateKeyPair(crypto.Ed25519, -1) | ||
| require.NoError(t, err) | ||
| pid, err := peer.IDFromPublicKey(pub) | ||
| require.NoError(t, err) | ||
| return pid | ||
| } |
There was a problem hiding this comment.
This can be replaced by random.Peers
Comment on lines
+109
to
+114
| peers := make([]peer.ID, nPeers) | ||
| peersTrie := trie.New[bit256.Key, peer.ID]() | ||
| for i := range peers { | ||
| peers[i] = genRandPeerID(t) | ||
| peersTrie.Add(keyspace.PeerIDToBit256(peers[i]), peers[i]) | ||
| } |
There was a problem hiding this comment.
Suggested change
| peers := make([]peer.ID, nPeers) | |
| peersTrie := trie.New[bit256.Key, peer.ID]() | |
| for i := range peers { | |
| peers[i] = genRandPeerID(t) | |
| peersTrie.Add(keyspace.PeerIDToBit256(peers[i]), peers[i]) | |
| } | |
| peers := random.Peers(nPeers) | |
| peersTrie := trie.New[bit256.Key, peer.ID]() | |
| for _, peer := range peers { | |
| peersTrie.Add(keyspace.PeerIDToBit256(peer), peer) | |
| } |
gammazero
reviewed
Jul 25, 2025
| type SweepingProvider struct { | ||
| // TODO: implement me | ||
| // TODO: complete me |
There was a problem hiding this comment.
Maybe comment out the unused members so that linter does not complain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1095
Depends on #1114
Network operations performed by the provider.
providerafter provider: adding provide and reprovide queue #1114 is merged