provider: schedule prefix length #1116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gammazero
reviewed
Jul 25, 2025
| bytes := [32]byte{} | ||
| rand.Read(bytes[:]) | ||
| for { | ||
| if s.closed() { |
There was a problem hiding this comment.
Maybe move this outside the loop and have Close wait for any calls to measureInitialPrefixLen to complete.
gammazero
reviewed
Jul 25, 2025
| if s.closed() { | ||
| return | ||
| } | ||
| peers, err := s.router.GetClosestPeers(context.Background(), string(bytes[:])) |
There was a problem hiding this comment.
Should the returned err be logged or handled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1095
Depends on #1115
The provider schedule (introduced in follow up PR) stores a mapping
prefix -> timestamp, corresponding to the time at which a keyspace region represented by its prefix should be reprovided. When reproviding a region, all keys matching the region's prefix will be reprovided.Whenever users want to provide a key with
StartProviding, if no prefix of the key is in the schedule yet, we take a prefix of the key whose length is the average of the prefixes already in the schedule (assume the keyspace region has the same peers population density as the average population density in teh DHT swarm).When the schedule is empty, we make a couple
GetClosestPeersrequests in order to have an approximation of the network size, helping to determine the initial prefix length to be used in the schedule.Note that no network provide can happen before
measureInitialPrefixLenhas completed.measureInitialPrefixLenwill block untilGetClosestPeersreturn some peers, so it requires the node to have a connection, and therouter(DHT client) to be bootstrapped. Anyway, if the DHT client isn't bootstrapped, no provide operation can succeed.providerafter provider: network operations #1115 is merged