provider: adding provide and reprovide queue #1114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
2 tasks
gammazero
approved these changes
Jul 25, 2025
Comment on lines
+30
to
+37
| // Prefix is a prefix of (at least) an existing prefix in the queue. | ||
| entriesToRemove := keyspace.AllEntries(subtrie, bit256.ZeroKey()) | ||
| prefixesToRemove := make([]bitstr.Key, len(entriesToRemove)) | ||
| for i, entry := range entriesToRemove { | ||
| prefixesToRemove[i] = entry.Key | ||
| } | ||
| // Remove superstrings of `prefix` from the queue | ||
| firstRemovedIndex := q.removePrefixesFromQueue(prefixesToRemove) |
There was a problem hiding this comment.
These lines are also present in Remove. Maybe put them into a function.
Comment on lines
+19
to
+26
| digest := make([]byte, 32) | ||
| if _, err := rand.Read(digest); err != nil { | ||
| panic(err) | ||
| } | ||
| h, err := mh.Encode(digest, mh.SHA2_256) | ||
| if err != nil { | ||
| panic(err) | ||
| } |
There was a problem hiding this comment.
Look at random.Multihashes or even random.Bytes
Suggested change
| digest := make([]byte, 32) | |
| if _, err := rand.Read(digest); err != nil { | |
| panic(err) | |
| } | |
| h, err := mh.Encode(digest, mh.SHA2_256) | |
| if err != nil { | |
| panic(err) | |
| } | |
| h := random.Multihashes(1)[0] |
| panic(err) | ||
| } | ||
| k := keyspace.MhToBit256(h) | ||
| if keyspace.IsPrefix(prefix, k) { |
There was a problem hiding this comment.
Instead of finding enough multihashes that have the prefix by chance, consider generating the requested number of random multihashes, and overwriting them to have the correct prefix.
| // queue. It assumes the mutex is held already. | ||
| func (q *ProvideQueue) sizeNoLock() int { | ||
| return q.keys.Size() | ||
| } |
There was a problem hiding this comment.
This seems like an unnecessary function. Would it be better to just call q.keys.Size()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1095
This PR adds 2 queues implementations:
Reprovide queue
This queue keeps track of the prefixes associated with the keyspace regions that should be reprovided as soon as possible. These regions end up in the queue if the provider failed to reprovide them on time.
Provide queue
This queue keeps track of all the keys that should be provided as soon as possible. The keys are grouped by common prefix to optimize batch providing.
Both queues make use of the
prefixQueue.