Skip to content

Conversation

@jeremyforan
Copy link

Issue:
The build is failing because the code (or one of its dependencies) uses the maps package, which was introduced in Go 1.21. Our CI runner is currently configured to use Go 1.19, which does not include this package.

The failed build

Error: ../../../go/pkg/mod/github.com/aws/smithy-go@v1.22.3/properties.go:3:8: package maps is not in GOROOT (/opt/hostedtoolcache/go/1.19.13/x64/src/maps)
Error: Process completed with exit code 1.

Solution:
Update the workflow configuration to use Go latest, stable version.

@AndrianBdn
Copy link
Collaborator

@jeremyforan Thanks for the PR. Can you update it to align with recent changes?

  • Keep the GitHub Action update (looks good)
  • Don't modify the examples - those were recently updated
  • Revert the go.mod module path change; it must remain libdns/route53. You can still update the Go version and dependencies.

Simplest option may be to open a new PR that only updates dependencies and the GitHub Actions workflow.

@AndrianBdn
Copy link
Collaborator

Closing in favor of #290

@AndrianBdn AndrianBdn closed this Sep 25, 2025
@AndrianBdn
Copy link
Collaborator

Thanks @jeremyforan for the PR. I've recently become a contributor to this repository, and we'd be glad to see more PRs from you if you’re interested in helping with libdns/route53 development. For this case, I had to update GHA and dependencies myself to move development forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants