Skip to content

Conversation

robin-carlier
Copy link
Collaborator

As pointed in the thread for #30586, the attribute [grind →] on IsAdmissible.singleton causes unwanted instantiations as the only hypothesis is too generic.

The lemma is un-grinded and the only proof that uses it now calls it explicitly.


Open in Gitpod

Copy link

PR summary 577ebdb9cc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@robin-carlier robin-carlier added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 20, 2025
Copy link
Contributor

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 20, 2025
@grunweg
Copy link
Collaborator

grunweg commented Oct 21, 2025

It seems bors didn't notice this one, let's try again:
bors merge

mathlib-bors bot pushed a commit that referenced this pull request Oct 21, 2025
…IsAdmissible.singleton` (#30732)

As pointed in the thread for #30586, the attribute `[grind →]` on `IsAdmissible.singleton` causes unwanted instantiations as the only hypothesis is too generic.

The lemma is un-grinded and the only proof that uses it now calls it explicitly.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(AlgebraicTopology/SimplexCategory/GeneratorsRelations): ungrind IsAdmissible.singleton [Merged by Bors] - fix(AlgebraicTopology/SimplexCategory/GeneratorsRelations): ungrind IsAdmissible.singleton Oct 21, 2025
@mathlib-bors mathlib-bors bot closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebraic-topology Algebraic topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants