Skip to content

Conversation

linesthatinterlace
Copy link
Collaborator

Give SimplexCategoryGenRel.IsAdmissible an inductive definition equivalent to its prior definition.


When working on another PR, I noticed that the definition of SimplexCategoryGenRel.IsAdmissible could be substantially improved. In particular, it admits a nice natural inductive definition, which then obviously gives you the option of inducting on it directly, but just in general makes it much nicer and smoother to work with (and it isn't hard to prove it is equivalent to the previous definition).

I think there's probably more golfing one could do in this file but for now I've tried to do enough to demonstrate the value of the new definition at least.

Open in Gitpod

Copy link

github-actions bot commented Oct 15, 2025

PR summary 2528a23415

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ IsAdmissible.simplicialEvalσ_succ_getElem
+ IsChain.cons
+ IsChain.of_cons
+ getElem_lt
+ isAdmissible_cons_cons_iff
+ isAdmissible_cons_iff
+ isAdmissible_iff_isChain_and_le
+ isAdmissible_iff_pairwise_and_le
+ isAdmissible_of_isChain_of_forall_getElem_le
+ isAdmissible_singleton_iff
+ isChain
+ mono
+ of_cons
+ pairwise
+ simplicialEvalσ_of_le_mem
- nil

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type
4856 -1 exceptions for the docPrime linter

Current commit 0e7bf6534a
Reference commit 2528a23415

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@robin-carlier robin-carlier added the t-algebraic-topology Algebraic topology label Oct 15, 2025
@robin-carlier robin-carlier self-assigned this Oct 15, 2025
Copy link
Collaborator

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This definitely improves some of the proofs, I could check that #21746 only needs minimal modifications for this, so that’s nice. #21747 needs a lot of refactor to adapt previous merges anyways, and makes almost no use of admissible lists, so things should be fine.

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 16, 2025
@linesthatinterlace linesthatinterlace removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 16, 2025
@mathlib4-merge-conflict-bot mathlib4-merge-conflict-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 17, 2025
@mathlib4-merge-conflict-bot
Copy link
Collaborator

This pull request has conflicts, please merge master and resolve them.

Copy link
Collaborator

@robin-carlier robin-carlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor nits + possible golfs, but basically looks good!

The merge conflict seems to come from some typos being fixed, so should be ok to resolve.

@robin-carlier robin-carlier added the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 17, 2025
@github-actions github-actions bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Oct 17, 2025
@robin-carlier robin-carlier removed the awaiting-author A reviewer has asked the author a question or requested changes. label Oct 17, 2025
@robin-carlier
Copy link
Collaborator

Thanks!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by robin-carlier.

@joelriou
Copy link
Collaborator

Thanks!

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Oct 17, 2025
mathlib-bors bot pushed a commit that referenced this pull request Oct 17, 2025
Give `SimplexCategoryGenRel.IsAdmissible` an inductive definition equivalent to its prior definition.

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: Improve definition of SimplexCategoryGenRel.IsAdmissible [Merged by Bors] - fix: Improve definition of SimplexCategoryGenRel.IsAdmissible Oct 17, 2025
@mathlib-bors mathlib-bors bot closed this Oct 17, 2025
YaelDillies pushed a commit to YaelDillies/mathlib4 that referenced this pull request Oct 17, 2025
…prover-community#30586)

Give `SimplexCategoryGenRel.IsAdmissible` an inductive definition equivalent to its prior definition.

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebraic-topology Algebraic topology

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants