-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - fix: Improve definition of SimplexCategoryGenRel.IsAdmissible
#30586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - fix: Improve definition of SimplexCategoryGenRel.IsAdmissible
#30586
Conversation
PR summary 2528a23415Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Current number | Change | Type |
---|---|---|
4856 | -1 | exceptions for the docPrime linter |
Current commit 0e7bf6534a
Reference commit 2528a23415
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
…e/mathlib4 into is_admissible_refactor
This pull request has conflicts, please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor nits + possible golfs, but basically looks good!
The merge conflict seems to come from some typos being fixed, so should be ok to resolve.
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Mathlib/AlgebraicTopology/SimplexCategory/GeneratorsRelations/NormalForms.lean
Outdated
Show resolved
Hide resolved
Thanks! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by robin-carlier. |
Thanks! bors merge |
Give `SimplexCategoryGenRel.IsAdmissible` an inductive definition equivalent to its prior definition. Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
SimplexCategoryGenRel.IsAdmissible
SimplexCategoryGenRel.IsAdmissible
…prover-community#30586) Give `SimplexCategoryGenRel.IsAdmissible` an inductive definition equivalent to its prior definition. Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Give
SimplexCategoryGenRel.IsAdmissible
an inductive definition equivalent to its prior definition.When working on another PR, I noticed that the definition of SimplexCategoryGenRel.IsAdmissible could be substantially improved. In particular, it admits a nice natural inductive definition, which then obviously gives you the option of inducting on it directly, but just in general makes it much nicer and smoother to work with (and it isn't hard to prove it is equivalent to the previous definition).
I think there's probably more golfing one could do in this file but for now I've tried to do enough to demonstrate the value of the new definition at least.