Skip to content

Conversation

Ruben-VandeVelde
Copy link
Collaborator


Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the easy < 20s of review time. See the lifecycle page for guidelines. label Oct 14, 2025
@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Oct 14, 2025
Copy link

PR summary ac33158d9a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ is_closed'
+ is_irreducible'

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Copy link
Collaborator

@grunweg grunweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted; thanks for fixing!
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by grunweg.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Oct 15, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename IrreducibleCloseds fields to match naming convention [Merged by Bors] - chore: rename IrreducibleCloseds fields to match naming convention Oct 15, 2025
@mathlib-bors mathlib-bors bot closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants