-
Notifications
You must be signed in to change notification settings - Fork 681
feat: replace every usage of ⬝ᵥ (with old \cdot) by ·ᵥ (with \centerdot) #27399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: replace every usage of ⬝ᵥ (with old \cdot) by ·ᵥ (with \centerdot) #27399
Conversation
PR summary d3c295b45dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
Please put the PR description above the |
-/ | ||
def mulVec [Fintype n] (M : Matrix m n α) (v : n → α) : m → α | ||
| i => (fun j => M i j) ⬝ᵥ v | ||
| i => (fun j => M i j) ·ᵥ v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be a good idea to split this PR; so do a replavement of ·ᵥ
back with ⬝ᵥ
, since it seems all the other dots are just mistakes! Then we can replace just dotProduct
in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have rolled back all changes, and in this pr replace only the dotproduct notation.
(i saw your message after i had already edited everything here, sorry).
How can i build a pr on top of this one? The other one would change all the comments, leaving only the homotopy product with the \cdot variant
This reverts commit b916d84.
@@ -25,7 +25,7 @@ This file defines vector and matrix multiplication | |||
|
|||
The locale `Matrix` gives the following notation: | |||
|
|||
* `⬝ᵥ` for `dotProduct` | |||
* `·ᵥ` for `dotProduct` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I claim we should actually use
* `·ᵥ` for `dotProduct` | |
* `⋅ᵥ` for `dotProduct` |
but let's wait for a zulip opinion
Discussion at zulip.
Currently the abbreviations
\cdot
and\centerdot
resolve to different, with the naked eye nearly undistinguishable symbols (despite the c in cdot surely standing forcenter
..):\cdot
gives ⬝ U+2B1D "Black Very Small Square"\centerdot
gives · U+00B7 "Middle Dot"Mathlib mostly uses the
\centerdot
variant, except for the dotProduct notation and some probably unsuspecting people wanting \centerdot but getting \cdot in their comments and 6 uses of a notation using the raw\cdot
without any subscript atMathlib\Topology\Homotopy\Product.lean
.This PR replaces the dot product
⬝ᵥ
with its\centerdot
counterpart·ᵥ
. The related PR here can then overwrite the\cdot
abbreviation, to produce the same symbol as thecenterdot
abbreviation does.