-
Notifications
You must be signed in to change notification settings - Fork 681
feat: replace probably erroneous usage of ⬝ (with old \cdot) by · (with \centerdot) #27403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: replace probably erroneous usage of ⬝ (with old \cdot) by · (with \centerdot) #27403
Conversation
This reverts commit b916d84.
PR summary d3c295b45dImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
@@ -296,7 +296,7 @@ theorem mul_apply {l : Type*} [Fintype m] [Mul A] [AddCommMonoid A] {M : CStarMa | |||
{N : CStarMatrix m n A} {i k} : (M * N) i k = ∑ j, M i j * N j k := rfl | |||
|
|||
theorem mul_apply' {l : Type*} [Fintype m] [Mul A] [AddCommMonoid A] {M : CStarMatrix l m A} | |||
{N : CStarMatrix m n A} {i k} : (M * N) i k = (fun j => M i j) ⬝ᵥ fun j => N j k := rfl | |||
{N : CStarMatrix m n A} {i k} : (M * N) i k = (fun j => M i j) ·ᵥ fun j => N j k := rfl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you revert these dotProduct changes to make the PR orthogonal? you can just find and replace this digraph back with the original
Discussion at zulip.
Currently the abbreviations \cdot and \centerdot resolve to different, with the naked eye nearly undistinguishable symbols (despite the c in cdot surely standing for center..).
This pr replaces instances of ⬝ where · was probably meant.
All of the replacement is in comments, except for the file bench_summary.lean which is used for priting the github benchmark results. Since this file is about scientific notation of numbers, sure · was meant to be used, not a rectangle.
Related