-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - feat(CI): add emoji to maintainer merge'd PRs also #24544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
PR summary e2a5289bd7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Just one question: hammer
is an "official" name for the emoji? If the emoji is a custom emoji, then I think that we should also track down some internal ID number, like for the closed PR
emoji.
Yes, 🔨 is an official emoji. See e.g here or try the signal messenger. |
I just pushed another commit, merging the two essentially duplicate workflows into one. |
Thanks, I like the newer version, let's try it out! bors merge |
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
Pull request successfully merged into master. Build succeeded: |
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
The zulip bot reacts to all label changes, including arbitrary users setting that label. That seems harmless: the emoji is only informational, and the effect of false marking a PR with the label may simply be that it doesn't reviewed as well.
This PR is cargo-culted, please review carefully.