-
Notifications
You must be signed in to change notification settings - Fork 839
[Merged by Bors] - refactor(zulip-emoji-merge-delegate.py): consolidate repeated logic #24545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR summary f17197c039Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for No changes to technical debt.You can run this locally as
|
This fixes the message for delegate emojis, to say 'delegated' and not 'peace_sign'.
cf54236
to
0d36030
Compare
This PR/issue depends on:
|
Not sure from the discussion in Zulip if this is still being tested but LGTM. |
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
I would say: yes, this is being tested - but the logic change is orthogonal to this refactoring, so let's land this first. Thanks for the quick review! |
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
Pull request successfully merged into master. Build succeeded: |
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
…24545) This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
This script repeats the same logic for all ~5 different emojis now: extract the logic into short functions to make the code shorter.
Commits are best reviewed individually.