Skip to content

Conversation

@kyeotic
Copy link
Owner

@kyeotic kyeotic commented Mar 13, 2025

fixes #136

@areebahmeddd
Copy link

areebahmeddd commented Mar 13, 2025

Update: still working on it. Running tests locally with act cli

@areebahmeddd
Copy link

areebahmeddd commented Mar 13, 2025

The fail on size workflow can be fixed with this: (package.json)

{BDE57E20-A006-49BF-BA54-69A6B4F99CCE}

I've got this fix for the builds on my local, pushing the changes in a moment. Do we require 12.x?

{95610257-B1F8-4C83-B55A-0164002F94DD}

@kyeotic
Copy link
Owner Author

kyeotic commented Mar 13, 2025

@areebahmeddd Size limit is working locally, and failing in CI. Buh.

@areebahmeddd
Copy link

areebahmeddd commented Mar 13, 2025

@kyeotic It's cool, i've got the fix. Just a second while i clean up some changes before committing

@areebahmeddd
Copy link

You've got a successful check for Size? is it the right way of doing? Should i update my PR?
I've got successful check for all the builds

@kyeotic kyeotic merged commit 5e4e991 into main Mar 13, 2025
5 checks passed
@kyeotic kyeotic deleted the actions-chores branch March 13, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix deprecated GitHub Actions in CI workflow

3 participants