Skip to content

Conversation

@areebahmeddd
Copy link

@areebahmeddd areebahmeddd commented Mar 13, 2025

Signed-off-by: Areeb Ahmed hi@areeb.cloud

Summary of Changes

Fixes: #136

  • Replaced outdated v1 actions with latest versions.

EDIT: Took me 2 hours to do experiment with our broken dependencies lmao (also re wrote the workflows with better syntax)

@areebahmeddd areebahmeddd requested a review from kyeotic as a code owner March 13, 2025 17:39
@kyeotic
Copy link
Owner

kyeotic commented Mar 13, 2025

The changes to upload-artifact cause a conflict for matrix runs, and there is a rollup/tslib issue causing build failures. Im also trying to work those out

@areebahmeddd
Copy link
Author

areebahmeddd commented Mar 13, 2025

@kyeotic Check this?

{C9203619-6887-43BD-B7D1-13C7C60F5742}

Works for defined node version matrix :)

{C568CDEF-DFEE-4784-A609-7399E96DE651}

@kyeotic
Copy link
Owner

kyeotic commented Mar 13, 2025

Same failure I'm getting

@areebahmeddd
Copy link
Author

areebahmeddd commented Mar 13, 2025

@kyeotic Yay only size is messing up HAHA. Can you review the changes done in Test.yaml?

@areebahmeddd
Copy link
Author

@kyeotic Could you run this action?

@kyeotic
Copy link
Owner

kyeotic commented Mar 13, 2025

Im taking #138 in favor of this.

Thank you for the PR though, it was helpful in narrowing down issues. 🥂

@kyeotic kyeotic closed this Mar 13, 2025
@areebahmeddd areebahmeddd deleted the feat/upgrade-versions branch March 13, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants