🐛 Adding image pull policy tag

[adarshagrawal38]

Adding image pull policy tag to the helm template
Fixing issue: #4859

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adarshagrawal38
Once this PR has been reviewed and has the lgtm label, please assign kavinjsir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @adarshagrawal38!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @adarshagrawal38. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Do we have an image policy in the kustomize default config?

[adarshagrawal38]

Hi I am sure where to check this

[camilamacedo86]

Thanks so much for the contribution! 🙌 This is really appreciated.

The purpose of the Helm Chart plugin is to allow the solution to be packaged and distributed.

Therefore, we want to keep the Helm chart aligned with how Kubebuilder scaffolds projects.
That means we cannot make the Helm Chart layout deviate from what is done in the project's scaffolds.

Just to share, I am OK with we do the changes (assuming that we do all align) for now, but I think the direction will be to change how we do it, see: #4833

---

Review / Regards the Changes

📌 Here's some context that might help:

• The manager config is scaffolded here:
  https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/common/kustomize/v2/scaffolds/internal/templates/config/manager/config.go#L47-L145
  → So maybe we could add the ImagePolicy here too?

• For Helm, the manager is scaffolded separately here:
  https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/manager/manager.go#L58-L159
  → So it looks like the policy may also need to be set in this Helm-specific file.

• Default values are exposed here for users:
  https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/values.go#L55-L143
  → If we want this field configurable, it probably needs to be added here too.

Just sharing for awareness: there’s a discussion about how values are exposed in Helm:
#4912
(This might change in the future—but totally out of scope for this PR!)

---

Let me know what you think! Happy to clarify anything if needed 😊

[adarshagrawal38]

Hi @camilamacedo86, thanks for the explanation, I have updated the PR please have a look

[adarshagrawal38]

Hi @camilamacedo86, do we still need this PR?
I see another PR is raised to do same.

[camilamacedo86]

Hi @camilamacedo86, do we still need this PR?
I see another PR is raised to do same.

We have another PR: #4952 proposal, but it seems to be doing more than should be done by @ronaldosaheki. Therefore, I am unsure if @ronaldosaheki will modify their PR.

Let's speak in the Slack channel kubebuilder.