Skip to content

Helm plugin add imagePullPolicy field #4859

@fdpeiter

Description

@fdpeiter

What do you want to happen?

Hello there.

I wanted to know if it is possible to add the imagePullPolicy to the helm-plugin manager template. It is a small change and I am happy to push a PR.

It's basically add to https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/manager/manager.go#L94:

          image: {{ "{{ .Values.controllerManager.container.image.repository }}" }}:{{ "{{ .Values.controllerManager.container.image.tag }}" }}
          {{ "{{- if .Values.controllerManager.container.imagePullPolicy }}" }}
          imagePullPolicy: {{ "{{ .Values.controllerManager.container.imagePullPolicy }}" }}
          {{ "{{- end }}" }}
          {{ "{{- if .Values.controllerManager.container.env }}" }}

Let me know if it makes sense and I should proceed. Thanks in advance.

Extra Labels

No response

Metadata

Metadata

Labels

kind/featureCategorizes issue or PR as related to a new feature.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions