⚠️ kube aware logger which could also work with logger.WithValues #1883

STRRL · 2022-05-03T07:42:31Z

Signed-off-by: STRRL im@strrl.dev

This PR could fix #1290

As this comment says, the latest logr provide logr.Marshaler, it could be used instead the current "kube-aware-logger-things" implementation with custom zap encoder

k8s-ci-robot · 2022-05-03T07:42:38Z

Welcome @STRRL!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-05-03T07:42:39Z

Hi @STRRL. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

STRRL · 2022-05-03T10:34:27Z

Hi! I think this PR is ready for view.

/cc @timebertt

k8s-ci-robot · 2022-05-03T10:34:29Z

@STRRL: GitHub didn't allow me to request PR reviews from the following users: timebertt.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Hi! I think this PR is ready for view.

/cc @timebertt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

STRRL · 2022-07-13T06:26:50Z

PTAL

/cc @FillZpp

camilamacedo86 · 2022-07-16T06:49:38Z

examples/configfile/builtin/main.go

 	"sigs.k8s.io/controller-runtime/pkg/manager/signals"
 )

 var scheme = runtime.NewScheme()

 func init() {
-	log.SetLogger(zap.New())
+	log.SetLogger(bootstrap.New())


It is a breaking change for those who are importing controller runtime.
Can you please use the emoji :warning: ?

Also, do we need to change the lib?

alvaroaleman · 2022-07-16T16:44:36Z

pkg/log/zap/zap.go

@@ -39,6 +39,7 @@ type NewEncoderFunc func(...EncoderConfigOption) zapcore.Encoder
 // New returns a brand new Logger configured with Opts. It
 // uses KubeAwareEncoder which adds Type information and
 // Namespace/Name to the log.
+// Deprecated: use bootstrap.New as instead.


What is the reason for moving things around? If anyhow possible, lets avoid this. All existing projects will need to be updated to get this fix, that is something we absolutely want to avoid.

What is the reason for moving things around?

I think using zap as the package name might bring confusion to users because we actually do not use zap.Logger but logr.Logger.

As the controller-runtime still stay with 0.x.x, I think maybe it would be friendly to introduce breaking changes right now rather than bring breaking changes after the stable 1.x.x. ❤️

If anyhow possible, lets avoid this.

I would make it a try! :D

alvaroaleman · 2022-07-16T16:45:27Z

/ok-to-test

k8s-triage-robot · 2023-05-17T16:35:12Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2023-06-16T17:12:52Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2023-07-16T17:35:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2023-07-16T17:35:38Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

STRRL · 2024-11-26T14:01:03Z

/reopen

k8s-ci-robot · 2024-11-26T14:01:10Z

@STRRL: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: STRRL <im@strrl.dev>

k8s-triage-robot · 2024-12-26T15:04:56Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-12-26T15:05:01Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

STRRL · 2025-01-03T19:38:29Z

:(

caozhuozi · 2025-03-20T07:58:23Z

!

sbueringer · 2025-03-21T07:20:35Z

/reopen
/remove-lifecycle rotten

(I don't have bandwidth to review atm though)

k8s-ci-robot · 2025-03-21T07:20:40Z

@sbueringer: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

(I don't have bandwidth to review atm though)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-03-21T07:20:45Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: STRRL
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2025-03-21T07:20:47Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2025-03-21T07:20:55Z

@STRRL: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-controller-runtime-apidiff	`2b18179`	link	false	`/test pull-controller-runtime-apidiff`
pull-controller-runtime-test	`2b18179`	link	true	`/test pull-controller-runtime-test`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2022

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 3, 2022

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 3, 2022

k8s-ci-robot requested review from alenkacz and alvaroaleman May 3, 2022 07:42

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 3, 2022

STRRL marked this pull request as ready for review May 3, 2022 10:33

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2022

k8s-ci-robot requested a review from varshaprasad96 May 3, 2022 10:34

k8s-ci-robot requested a review from FillZpp July 13, 2022 06:26

camilamacedo86 reviewed Jul 16, 2022

View reviewed changes

alvaroaleman reviewed Jul 16, 2022

View reviewed changes

alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 16, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2022

STRRL changed the title ~~🐛 kube aware logger which could also work with logger.WithValues~~ ⚠️ 🐛 kube aware logger which could also work with logger.WithValues Jul 17, 2022

STRRL changed the title ~~⚠️ 🐛 kube aware logger which could also work with logger.WithValues~~ ⚠️ kube aware logger which could also work with logger.WithValues Jul 17, 2022

STRRL force-pushed the kube-aware-logr-logger branch from 2268f75 to 42e1664 Compare July 17, 2022 03:02

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 17, 2022

STRRL force-pushed the kube-aware-logr-logger branch 2 times, most recently from da24bda to 521d348 Compare July 17, 2022 03:05

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2023

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 16, 2023

k8s-ci-robot closed this Jul 16, 2023

STRRL mentioned this pull request Nov 26, 2024

logger.WithValues bypasses KubeAwareEncoder #1290

Open

k8s-ci-robot reopened this Nov 26, 2024

Merge remote-tracking branch 'upstream/main' into kube-aware-logr-logger

8758ead

k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 26, 2024

chore: make modules for sync deps

2b18179

Signed-off-by: STRRL <im@strrl.dev>

k8s-ci-robot closed this Dec 26, 2024

k8s-ci-robot reopened this Mar 21, 2025

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 21, 2025

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 21, 2025

caozhuozi mentioned this pull request May 8, 2025

🐛 let logr.Logger understand Kubernetes Object #3210

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ kube aware logger which could also work with logger.WithValues #1883

⚠️ kube aware logger which could also work with logger.WithValues #1883

STRRL commented May 3, 2022 •

edited

Loading

k8s-ci-robot commented May 3, 2022

k8s-ci-robot commented May 3, 2022

STRRL commented May 3, 2022

k8s-ci-robot commented May 3, 2022

STRRL commented Jul 13, 2022

camilamacedo86 Jul 16, 2022

alvaroaleman Jul 16, 2022 •

edited

Loading

STRRL Jul 17, 2022

alvaroaleman commented Jul 16, 2022

k8s-triage-robot commented May 17, 2023

k8s-triage-robot commented Jun 16, 2023

k8s-triage-robot commented Jul 16, 2023

k8s-ci-robot commented Jul 16, 2023

STRRL commented Nov 26, 2024

k8s-ci-robot commented Nov 26, 2024

k8s-triage-robot commented Dec 26, 2024

k8s-ci-robot commented Dec 26, 2024

STRRL commented Jan 3, 2025

caozhuozi commented Mar 20, 2025

sbueringer commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

⚠️ kube aware logger which could also work with logger.WithValues #1883

Are you sure you want to change the base?

⚠️ kube aware logger which could also work with logger.WithValues #1883

Conversation

STRRL commented May 3, 2022 • edited Loading

k8s-ci-robot commented May 3, 2022

k8s-ci-robot commented May 3, 2022

STRRL commented May 3, 2022

k8s-ci-robot commented May 3, 2022

STRRL commented Jul 13, 2022

camilamacedo86 Jul 16, 2022

Choose a reason for hiding this comment

alvaroaleman Jul 16, 2022 • edited Loading

Choose a reason for hiding this comment

STRRL Jul 17, 2022

Choose a reason for hiding this comment

alvaroaleman commented Jul 16, 2022

k8s-triage-robot commented May 17, 2023

k8s-triage-robot commented Jun 16, 2023

k8s-triage-robot commented Jul 16, 2023

k8s-ci-robot commented Jul 16, 2023

STRRL commented Nov 26, 2024

k8s-ci-robot commented Nov 26, 2024

k8s-triage-robot commented Dec 26, 2024

k8s-ci-robot commented Dec 26, 2024

STRRL commented Jan 3, 2025

caozhuozi commented Mar 20, 2025

sbueringer commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

k8s-ci-robot commented Mar 21, 2025

STRRL commented May 3, 2022 •

edited

Loading

alvaroaleman Jul 16, 2022 •

edited

Loading