🐛 let logr.Logger understand Kubernetes Object #3210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1290
This addresses a long-standing bug.
An earlier attempt to fix this was made in #1883, but it hasn't received any reviews for a long time.
possible reasons include (in my opinion):
To address this,
To summary the changes I made,
logr
, which just makes a logr.Logger aware of runtime.Object.(The need for a separate package and the naming are open for discussion.)