Skip to content

⚠️ Migrate E2E tests to v1beta2 #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jul 10, 2025
Merged

⚠️ Migrate E2E tests to v1beta2 #12451

merged 31 commits into from
Jul 10, 2025
+570 −468

Conversation

sivchari
Copy link
Member

@sivchari sivchari commented Jul 6, 2025

What this PR does / why we need it:

Part of #11947

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 6, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2025
@sivchari
Copy link
Member Author

sivchari commented Jul 6, 2025

/cc @sbueringer @fabriziopandini

@sivchari
Copy link
Member Author

sivchari commented Jul 7, 2025

/retest

@sivchari sivchari force-pushed the migrate-e2e branch 2 times, most recently from 8a107d9 to 8e8362f Compare July 7, 2025 03:23
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 7, 2025
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Jul 7, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jul 7, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jul 7, 2025
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sivchari sivchari force-pushed the migrate-e2e branch 3 times, most recently from f784894 to 63793b4 Compare July 8, 2025 07:05
@sivchari
Copy link
Member Author

sivchari commented Jul 8, 2025

/test ?

@k8s-ci-robot
Copy link
Contributor

@sivchari: The following commands are available to trigger required jobs:

/test pull-cluster-api-build-main

/test pull-cluster-api-e2e-blocking-main

/test pull-cluster-api-e2e-conformance-ci-latest-main

/test pull-cluster-api-e2e-conformance-main

/test pull-cluster-api-e2e-latestk8s-main

/test pull-cluster-api-e2e-main

/test pull-cluster-api-e2e-mink8s-main

/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

/test pull-cluster-api-test-main

/test pull-cluster-api-test-mink8s-main

/test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

/test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

pull-cluster-api-apidiff-main

pull-cluster-api-build-main

pull-cluster-api-e2e-blocking-main

pull-cluster-api-test-main

pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sivchari
Copy link
Member Author

sivchari commented Jul 8, 2025

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sbueringer
Copy link
Member

sbueringer commented Jul 8, 2025 •
edited
Loading

@sivchari Is this already rebased on top of latest main? The autoscaler failure looks like something I already fixed on a previous PR

But it would be strange in any case. I thought I broke and fixed it in #12299 (see changes to scale.go)

@sivchari
Copy link
Member Author

/retest

@sivchari

This comment was marked as duplicate.

Sign in to view
@sivchari
add json patches
bd6079e 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari

This comment was marked as duplicate.

Sign in to view
@sbueringer
Copy link
Member

@sivchari I'll fix this up locally, test it locally until it works and then push a fix

@sivchari
convert to list from map
c89d73b 
Signed-off-by: sivchari <shibuuuu5@gmail.com>
@sivchari
Copy link
Member Author

@sbueringer
Thanks, I push to fix the type from map to list, but I also try it locally.

@sivchari
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sbueringer sbueringer mentioned this pull request Jul 10, 2025
Closed
@sbueringer
Copy link
Member

@sivchari I'm hopeful that the last two commits on #12471 fix everything

@sivchari
Copy link
Member Author

Let's wait the result. Really really appreciate it!

@sbueringer
Copy link
Member

Let's wait the result. Really really appreciate it!

Yup, that's fine.

@sivchari
Copy link
Member Author

If the CI passes, I cherry-pick your 2 commits into this PR. 😄

@sivchari
Copy link
Member Author

sivchari commented Jul 10, 2025 •
edited
Loading

@sbueringer
Done! Let's wait the result.
We'll see all green 😄

@sivchari
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main
/test pull-cluster-api-e2e-latestk8s-main
/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main
/test pull-cluster-api-e2e-upgrade-1-33-1-34-main

@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve

(I'll override e2e test failures if they fail as expected)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c6b187032acf430a6f8d5499e7a268ce4befedb

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2025
@sbueringer
Copy link
Member

🎉 As expected

/override pull-cluster-api-e2e-latestk8s-main
/override pull-cluster-api-e2e-main
/override pull-cluster-api-e2e-mink8s-main

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-latestk8s-main, pull-cluster-api-e2e-main, pull-cluster-api-e2e-mink8s-main

In response to this:

🎉 As expected

/override pull-cluster-api-e2e-latestk8s-main
/override pull-cluster-api-e2e-main
/override pull-cluster-api-e2e-mink8s-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot merged commit 4e7f5d2 into kubernetes-sigs:main Jul 10, 2025
24 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 10, 2025
@fabriziopandini
Copy link
Member

@sivchari thanks for this PR! this is a huge step forward and an important piece to validate the v1beta2 effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@elmiko elmiko Awaiting requested review from elmiko

@richardcase richardcase Awaiting requested review from richardcase

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
4 participants
@sivchari @sbueringer @k8s-ci-robot @fabriziopandini