Skip to content

Commit a56fe63

Browse files
committed
fix review findings
Signed-off-by: sivchari <shibuuuu5@gmail.com>
1 parent e67ba75 commit a56fe63

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

test/e2e/data/infrastructure-docker/main/cluster-template-upgrades-runtimesdk/cluster-runtimesdk.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ spec:
1515
topology:
1616
classRef:
1717
name: "quick-start-runtimesdk"
18-
namespace: '${CLUSTER_CLASS_NAMESPACE:-""}'
18+
namespace: '${CLUSTER_CLASS_NAMESPACE:-${NAMESPACE}}'
1919
version: "${KUBERNETES_VERSION}"
2020
controlPlane:
2121
nodeDeletionTimeoutSeconds: 30

test/e2e/data/infrastructure-docker/main/clusterclass-quick-start.yaml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ spec:
4747
apiVersion: infrastructure.cluster.x-k8s.io/v1beta2
4848
kind: DockerMachineTemplate
4949
name: quick-start-default-worker-machinetemplate
50+
# We are intentionally not setting the 'unhealthyConditions' here to test that the field is optional.
5051
machinePools:
5152
- class: default-worker
5253
template:
@@ -383,10 +384,13 @@ spec:
383384
controlPlane: true
384385
jsonPatches:
385386
- op: add
386-
path: "/spec/template/spec/kubeadmConfigSpec/clusterConfiguration/apiServer/extraArgs/-"
387+
path: "/spec/template/spec/kubeadmConfigSpec/clusterConfiguration/apiServer"
388+
value: {}
389+
- op: add
390+
path: "/spec/template/spec/kubeadmConfigSpec/clusterConfiguration/apiServer/extraArgs"
387391
value:
388-
name: admission-control-config-file
389-
value: "/etc/kubernetes/kube-apiserver-admission-pss.yaml"
392+
- name: admission-control-config-file
393+
value: "/etc/kubernetes/kube-apiserver-admission-pss.yaml"
390394
- op: add
391395
path: "/spec/template/spec/kubeadmConfigSpec/clusterConfiguration/apiServer/extraVolumes"
392396
value:

0 commit comments

Comments
 (0)