Skip to content

⚠️ Change .status.replicas fields to pointer + omitempty #12250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #10852

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels May 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2025
@sbueringer sbueringer mentioned this pull request May 20, 2025
71 tasks
@sbueringer sbueringer changed the title ⚠️ Change .status.replicas fields to pointer + omitempty [WIP] ⚠️ Change .status.replicas fields to pointer + omitempty May 20, 2025
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@sbueringer sbueringer added area/api Issues or PRs related to the APIs and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label May 20, 2025
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@sbueringer sbueringer changed the title [WIP] ⚠️ Change .status.replicas fields to pointer + omitempty ⚠️ Change .status.replicas fields to pointer + omitempty May 20, 2025
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @chrischdi @JoelSpeed

@sbueringer sbueringer force-pushed the pr-replica-counters branch from 19d1bbc to 95d2650 Compare May 20, 2025 16:49
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main

@JoelSpeed
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a80dd5ef29ca7dcb72b0e5ae56a4cdaf12f01f0f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@sbueringer sbueringer added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 21, 2025
@k8s-ci-robot k8s-ci-robot merged commit 266d4fb into kubernetes-sigs:main May 21, 2025
20 of 21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone May 21, 2025
@sbueringer sbueringer deleted the pr-replica-counters branch May 21, 2025 08:46
@sbueringer sbueringer mentioned this pull request May 21, 2025
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants