Fix review finding, update migration doc

Author: sbueringer

controlplane/kubeadm/internal/controllers/controller_test.go

@@ -1385,7 +1385,7 @@ kubernetesVersion: metav1.16.1
 		g.Expect(kcp.Finalizers).To(ContainElement(controlplanev1.KubeadmControlPlaneFinalizer))
 
 		g.Expect(kcp.Status.Selector).NotTo(BeEmpty())
-		g.Expect(ptr.Deref(kcp.Status.Replicas, 0)).To(BeEquivalentTo(1))
+		g.Expect(kcp.Status.Replicas).To(HaveValue(BeEquivalentTo(1)))
 		g.Expect(v1beta1conditions.IsFalse(kcp, controlplanev1.AvailableV1Beta1Condition)).To(BeTrue())
 		g.Expect(conditions.IsFalse(kcp, controlplanev1.KubeadmControlPlaneInitializedCondition)).To(BeTrue())
 
@@ -1626,7 +1626,7 @@ kubernetesVersion: metav1.16.1`,
 		g.Expect(kcp.Finalizers).To(ContainElement(controlplanev1.KubeadmControlPlaneFinalizer))
 
 		g.Expect(kcp.Status.Selector).NotTo(BeEmpty())
-		g.Expect(ptr.Deref(kcp.Status.Replicas, 0)).To(BeEquivalentTo(1))
+		g.Expect(kcp.Status.Replicas).To(HaveValue(BeEquivalentTo(1)))
 		g.Expect(v1beta1conditions.IsFalse(kcp, controlplanev1.AvailableV1Beta1Condition)).To(BeTrue())
 
 		// Verify that the kubeconfig is using the custom CA

docs/book/src/developer/providers/migrations/v1.10-to-v1.11.md

@@ -98,6 +98,7 @@ proposal because most of the changes described below are a consequence of the wo
 - See changes that apply to [all CRDs](#all-crds)
 - The `spec.progressDeadlineSeconds` field (deprecated since CAPI v1.9) has been removed
 - Replica counters are now consistent with replica counters from other resources
+  - `status.replicas` was made a pointer and omitempty was added
   - `status.readyReplicas` has now a new semantic based on machine's `Ready` condition
   - `status.availableReplicas` has now a new semantic based on machine's `Available` condition
   - `status.upToDateReplicas` has now a new semantic (and name) based on machine's `UpToDate` condition
@@ -111,6 +112,7 @@ proposal because most of the changes described below are a consequence of the wo
 
 - See changes that apply to [all CRDs](#all-crds)
 - Replica counters fields are now consistent with replica counters from other resources
+  - `status.replicas` was made a pointer and omitempty was added
   - `status.readyReplicas` has now a new semantic based on machine's `Ready` condition
   - `status.availableReplicas` has now a new semantic based on machine's `Available` condition
   - `status.upToDateReplicas` has now a new semantic (and name) based on machine's `UpToDate` condition
@@ -121,6 +123,7 @@ proposal because most of the changes described below are a consequence of the wo
 ### MachinePool
 
 - See changes that apply to [all CRDs](#all-crds)
+- `status.replicas` was made a pointer and omitempty was added
 - Support for terminal errors has been dropped.
   - `status.failureReason` and `status.failureMessage` will continue to exist temporarily under `status.deprecated.v1beta1`.
   - The const values for `Failed` phase has been deprecated in the enum type for `status.phase` (controllers are not setting this value anymore)
@@ -165,6 +168,7 @@ proposal because most of the changes described below are a consequence of the wo
 - KubeadmControlPlane (and the entire KCP provider) now implements the v1beta2 Cluster API contract.
 - See changes that apply to [all CRDs](#all-crds)
 - Replica counters fields are now consistent with replica counters from other resources.
+  - `status.replicas` was made a pointer and omitempty was added
   - `status.readyReplicas` has now a new semantic based on machine's `Ready` condition
   - `status.availableReplicas` has now a new semantic based on machine's `Available` condition
   - `status.upToDateReplicas` has now a new semantic (and name) based on machine's `UpToDate` condition