feat: add controller manager configuration helm chart

[kapil27]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2894

Checklist:

• Docs included if any changes are user facing

[coveralls]

Pull Request Test Coverage Report for Build 18674107727

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 112 unchanged lines in 5 files lost coverage.
• Overall coverage decreased (-0.5%) to 51.675%

---

Files with Coverage Reduction	New Missed Lines	%
pkg/runtime/framework/plugins/torch/torch.go	5	95.2%
pkg/webhooks/trainingruntime_webhook.go	13	60.0%
pkg/runtime/framework/plugins/mpi/mpi.go	18	85.27%
pkg/runtime/framework/plugins/jobset/builder.go	24	0.0%
pkg/runtime/runtime.go	52	54.74%

Totals
Change from base Build 18562606347:	-0.5%
Covered Lines:	1265
Relevant Lines:	2448

---

💛 - Coveralls

[andreyvelich]

Thanks for opening this @kapil27!
We are planning to cut v2.1.0-rc.0 today, is this PR ready to review ?

[andreyvelich]

Why do we need this ?

[kapil27]

You're right , we don't!
Removed the duplicate trainer.manager.serviceAccount.name helper from manager/_helpers.tpl. The helper already exists in rbac/_helpers.tpl

[andreyvelich]

Should it be true ?
https://github.com/kubeflow/trainer/blob/master/manifests/base/manager/controller_manager_config.yaml#L21

[kapil27]

Yes! Fixed the leader election configuration to default to true

[andreyvelich]

@kapil27 Can you also remove the post-fix generation from the ConfigMap in kustomize manifests:

trainer/manifests/base/manager/kustomization.yaml

Lines 6 to 8 in e6b5e84

	- name: kubeflow-trainer-config
	files:
	- controller_manager_config.yaml

[andreyvelich]

The name of the config map is:

kubeflow-trainer-config

[andreyvelich]

@kapil27 Did you get a chance to address the comments ?

[andreyvelich]

Thanks @kapil27!
/lgtm
/approve

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andreyvelich]

@kapil27 Are there any other changes you would like to make to this PR before we move forward ?

[kapil27]

@andreyvelich I’ve addressed all the comments and completed initial testing. It looks good on my end. ready to go ahead.