Trainer Config is missing in Helm Charts #2894
Description
What happened?
While deploying Kubeflow Trainer with Helm Charts it fails with the following error:
flag provided but not defined: -webhook-service-name
Usage of /manager:
-config string
The controller will load its initial configuration from this file. Omit this flag to use the default configuration values. Command-line flags override configuration from this file.
-enable-http2
If set, HTTP/2 will be enabled for the metrics and webhook servers
-kubeconfig string
Paths to a kubeconfig. Only required if out-of-cluster.
-zap-devel
Development Mode defaults(encoder=consoleEncoder,logLevel=Debug,stackTraceLevel=Warn). Production Mode defaults(encoder=jsonEncoder,logLevel=Info,stackTraceLevel=Error)
-zap-encoder value
Zap log encoding (one of 'json' or 'console')
-zap-log-level value
Zap Level to configure the verbosity of logging. Can be one of 'debug', 'info', 'error', 'panic'or any integer value > 0 which corresponds to custom debug levels of increasing verbosity
-zap-stacktrace-level value
Zap Level at and above which stacktraces are captured (one of 'info', 'error', 'panic').
-zap-time-encoding value
Zap time encoding (one of 'epoch', 'millis', 'nano', 'iso8601', 'rfc3339' or 'rfc3339nano'). Defaults to 'epoch'.
We should update the Helm Charts to support Config API
/cc @kapil27 @kubeflow/kubeflow-trainer-team
/good-first-issue
/area deployment
What did you expect to happen?
KF Trainer should be deployed with Helm Charts.
Environment
Kubernetes version:
$ kubectl version
Kubeflow Trainer version:
$ kubectl get pods -n kubeflow-system -l app.kubernetes.io/name=kubeflow-trainer -o jsonpath="{.items[*].spec.containers[*].image}"
Kubeflow Python SDK version:
$ pip show kubeflow
Impacted by this bug?
Give it a 👍 We prioritize the issues with most 👍