fix: update examples to reflect func_args now being unpacked #2815
+41
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Pull Request Test Coverage Report for Build 17529688495Details
💛 - Coveralls |
andreyvelich
reviewed
Sep 6, 2025
| "outputs": [], | ||
| "source": [ | ||
| "def deepspeed_train_t5(args):\n", | ||
| "def deepspeed_train_t5(NUM_SAMPLES, MODEL_NAME, BUCKET):\n", |
There was a problem hiding this comment.
Can you add the types for them please.
Suggested change
| "def deepspeed_train_t5(NUM_SAMPLES, MODEL_NAME, BUCKET):\n", | |
| "def deepspeed_train_t5(num_samples: str, model_name: str, bucket: str):\n", |
| "outputs": [], | ||
| "source": [ | ||
| "def mlx_train_mnist(args):\n", | ||
| "def mlx_train_mnist(BUCKET, MODEL):\n", |
There was a problem hiding this comment.
Suggested change
| "def mlx_train_mnist(BUCKET, MODEL):\n", | |
| "def mlx_train_mnist(bucket: str, model: str):\n", |
| "outputs": [], | ||
| "source": [ | ||
| "def fine_tune_llama(func_args):\n", | ||
| "def fine_tune_llama(HF_TOKEN, NUM_SAMPLES, BATCH_SIZE):\n", |
There was a problem hiding this comment.
Suggested change
| "def fine_tune_llama(HF_TOKEN, NUM_SAMPLES, BATCH_SIZE):\n", | |
| "def fine_tune_llama(hf_token: str, num_samples: str, batch_size: str):\n", |
| "outputs": [], | ||
| "source": [ | ||
| "def train_distilbert(args):\n", | ||
| "def train_distilbert(BUCKET, MODEL_NAME):\n", |
There was a problem hiding this comment.
Suggested change
| "def train_distilbert(BUCKET, MODEL_NAME):\n", | |
| "def train_distilbert(bucket: str = None, model_name: str):\n", |
There was a problem hiding this comment.
@andreyvelich Changes pushed
briangallagher
force-pushed
the
update-examples-with-unpacking-params
branch
2 times, most recently
from
b046202 to
e92dbc3
Compare
briangallagher
changed the title
andreyvelich
reviewed
Sep 6, 2025
There was a problem hiding this comment.
@briangallagher Can you rebase your PR to test GPU example as well ?
Signed-off-by: Brian Gallagher <briangal@gmail.com>
briangallagher
force-pushed
the
update-examples-with-unpacking-params
branch
from
e92dbc3 to
36b163a
Compare
Signed-off-by: Brian Gallagher <briangal@gmail.com>
briangallagher
force-pushed
the
update-examples-with-unpacking-params
branch
from
36b163a to
dd8f34d
Compare
andreyvelich
reviewed
Sep 7, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
astefanutti
pushed a commit
to astefanutti/training-operator
that referenced
this pull request
Sep 24, 2025
…w#2815) * update examples to reflect func_args now being unpacked Signed-off-by: Brian Gallagher <briangal@gmail.com> * fix: lower case func arguments and add types Signed-off-by: Brian Gallagher <briangal@gmail.com> --------- Signed-off-by: Brian Gallagher <briangal@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Update the examples to reflect the change to how parameters are passed to the training function.
The dictionary is now unpacked when calling the training function. See PR
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2801