Skip to content

Conversation

@astefanutti
Copy link
Contributor

What this PR does / why we need it:

Manual cherry-pick of #2815 in release-2.0 branch.

Checklist:

  • Docs included if any changes are user facing

…w#2815)

* update examples to reflect func_args now being unpacked

Signed-off-by: Brian Gallagher <briangal@gmail.com>

* fix: lower case func arguments and add types

Signed-off-by: Brian Gallagher <briangal@gmail.com>

---------

Signed-off-by: Brian Gallagher <briangal@gmail.com>
@google-oss-prow google-oss-prow bot added this to the v2.0 milestone Sep 24, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@astefanutti astefanutti changed the title fix: update examples to reflect func_args now being unpacked (#2815) [release-2.0] fix: update examples to reflect func_args now being unpacked (#2815) Sep 24, 2025
@astefanutti
Copy link
Contributor Author

astefanutti commented Sep 24, 2025

/retest

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 400591f into kubeflow:release-2.0 Sep 24, 2025
22 of 23 checks passed
@astefanutti astefanutti deleted the cherry-pick-2815 branch September 24, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants