Skip to content

fix: trainer client backend public #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
+10 −10
Merged

fix: trainer client backend public #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions kubeflow/trainer/api/trainer_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(
"""
# initialize training backend
if isinstance(backend_config, KubernetesBackendConfig):
self.__backend = KubernetesBackend(backend_config)
self.backend = KubernetesBackend(backend_config)
else:
raise ValueError("Invalid backend config '{}'".format(backend_config))

Expand All @@ -53,7 +53,7 @@ def list_runtimes(self) -> types.Runtime:
TimeoutError: Timeout to list Runtimes.
RuntimeError: Failed to list Runtimes.
"""
return self.__backend.list_runtimes()
return self.backend.list_runtimes()

def get_runtime(self, name: str) -> types.Runtime:
"""Get the Runtime object
Expand All @@ -62,7 +62,7 @@ def get_runtime(self, name: str) -> types.Runtime:
Returns:
types.TrainingRuntime: Runtime object.
"""
return self.__backend.get_runtime(name=name)
return self.backend.get_runtime(name=name)

def get_runtime_packages(self, runtime: types.Runtime):
"""
Expand All @@ -77,7 +77,7 @@ def get_runtime_packages(self, runtime: types.Runtime):
RuntimeError: Failed to get Runtime.

"""
return self.__backend.get_runtime_packages(runtime=runtime)
return self.backend.get_runtime_packages(runtime=runtime)

def train(
self,
Expand All @@ -104,7 +104,7 @@ def train(
TimeoutError: Timeout to create TrainJobs.
RuntimeError: Failed to create TrainJobs.
"""
return self.__backend.train(runtime=runtime, initializer=initializer, trainer=trainer)
return self.backend.train(runtime=runtime, initializer=initializer, trainer=trainer)

def list_jobs(self, runtime: Optional[types.Runtime] = None) -> List[types.TrainJob]:
"""List of all TrainJobs.
Expand All @@ -117,11 +117,11 @@ def list_jobs(self, runtime: Optional[types.Runtime] = None) -> List[types.Train
TimeoutError: Timeout to list TrainJobs.
RuntimeError: Failed to list TrainJobs.
"""
return self.__backend.list_jobs(runtime=runtime)
return self.backend.list_jobs(runtime=runtime)

def get_job(self, name: str) -> types.TrainJob:
"""Get the TrainJob object"""
return self.__backend.get_job(name=name)
return self.backend.get_job(name=name)

def get_job_logs(
self,
Expand All @@ -131,7 +131,7 @@ def get_job_logs(
node_rank: int = 0,
) -> Dict[str, str]:
"""Get the logs from TrainJob"""
return self.__backend.get_job_logs(name=name, follow=follow, step=step, node_rank=node_rank)
return self.backend.get_job_logs(name=name, follow=follow, step=step, node_rank=node_rank)

def wait_for_job_status(
self,
Expand All @@ -157,7 +157,7 @@ def wait_for_job_status(
RuntimeError: Failed to get TrainJob or TrainJob reaches unexpected Failed status.
TimeoutError: Timeout to wait for TrainJob status.
"""
return self.__backend.wait_for_job_status(
return self.backend.wait_for_job_status(
name=name,
status=status,
timeout=timeout,
Expand All @@ -174,4 +174,4 @@ def delete_job(self, name: str):
TimeoutError: Timeout to delete TrainJob.
RuntimeError: Failed to delete TrainJob.
"""
return self.__backend.delete_job(name=name)
return self.backend.delete_job(name=name)