-
Couldn't load subscription status.
- Fork 43
fix: trainer client backend public #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
Pull Request Test Coverage Report for Build 17340436659Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaiakash! I think, we should make backend public, so users can access values of TrainerClient().
/lgtm
/assign @szaher @kramaranya @astefanutti
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree we should keep it public. Thank you @jaiakash!
/lgtm
|
We probably shall add alpaca notebook to the e2e, so we cover this functionality as well, wdyt? @andreyvelich @jaiakash |
We are working on it as part of, which enables testing on GPUs: kubeflow/trainer#2762 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @andreyvelich @kramaranya |
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
What this PR does / why we need it:
This PR makes the backend attribute in TrainerClient publicly accessible. Currently, it is private, which restricts users from programmatically interacting with the underlying backend. Exposing it allows developers to extend functionality, debug, or customize backend usage more easily.
Fixes #77
Checklist: