Skip to content

Conversation

@jaiakash
Copy link
Member

What this PR does / why we need it:
This PR makes the backend attribute in TrainerClient publicly accessible. Currently, it is private, which restricts users from programmatically interacting with the underlying backend. Exposing it allows developers to extend functionality, debug, or customize backend usage more easily.

Fixes #77

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 17340436659

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.033%

Totals Coverage Status
Change from base Build 17296779530: 0.0%
Covered Lines: 292
Relevant Lines: 449

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jaiakash! I think, we should make backend public, so users can access values of TrainerClient().
/lgtm
/assign @szaher @kramaranya @astefanutti

Copy link
Contributor

@kramaranya kramaranya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should keep it public. Thank you @jaiakash!
/lgtm

@kramaranya
Copy link
Contributor

We probably shall add alpaca notebook to the e2e, so we cover this functionality as well, wdyt? @andreyvelich @jaiakash

@andreyvelich
Copy link
Member

We probably shall add alpaca notebook to the e2e, so we cover this functionality as well, wdyt? @andreyvelich @jaiakash

We are working on it as part of, which enables testing on GPUs: kubeflow/trainer#2762

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 06d77f9 into kubeflow:main Aug 30, 2025
9 checks passed
@google-oss-prow google-oss-prow bot added this to the v0.1 milestone Aug 30, 2025
@jaiakash
Copy link
Member Author

jaiakash commented Aug 30, 2025

Thanks @andreyvelich @kramaranya
I am already working on it as part of, which enables testing on GPUs: kubeflow/trainer#2762

accorvin pushed a commit to opendatahub-io/kubeflow-sdk that referenced this pull request Oct 8, 2025
Signed-off-by: Akash Jaiswal <akashjaiswal3846@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose backend in TrainerClient for direct access"

6 participants