Skip to content

chore: Move dev extras to dependency-groups #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 26, 2025
+15 −11
Merged

chore: Move dev extras to dependency-groups #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e684fdb
chore: Move dev extras to dependency-groups
kramaranya Aug 25, 2025
5b68ada
update uv sync command
kramaranya Aug 25, 2025
e143825
Merge branch 'main' into move-dev-to-deps
kramaranya Aug 25, 2025
90e4f77
add development build to CONTRIBUTING
kramaranya Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pip install -e .
#### Development Build (Optional)
To install development tools and the latest API modules directly from the master branch:
```sh
pip install -e ".[dev]"
uv pip install -e . --group dev
```

## Development Workflow
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ uv-venv:
# make test-python will produce html coverage by default. Run with `make test-python report=xml` to produce xml report.
.PHONY: test-python
test-python: uv-venv
@uv pip install -e ".[dev]"
@uv sync
@uv run coverage run --source=kubeflow.trainer.backends.kubernetes.backend,kubeflow.trainer.utils.utils -m pytest ./kubeflow/trainer/backends/kubernetes/backend_test.py
@uv run coverage report -m kubeflow/trainer/backends/kubernetes/backend.py kubeflow/trainer/utils/utils.py
ifeq ($(report),xml)
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ dependencies = [
"pydantic>=2.10.0",
"kubeflow-trainer-api>=2.0.0",
]
[project.optional-dependencies]

[dependency-groups]
dev = [
"pytest>=7.0",
"pytest-mock>=3.10",
Expand Down
19 changes: 11 additions & 8 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.